Storage: ensure that 'Blob.reload' passes encryption headers.#7441
Merged
tseaver merged 4 commits intogoogleapis:masterfrom Mar 14, 2019
tseaver:7440-storage-blob_reload_passes_enc_headers
Merged
Storage: ensure that 'Blob.reload' passes encryption headers.#7441tseaver merged 4 commits intogoogleapis:masterfrom tseaver:7440-storage-blob_reload_passes_enc_headers
tseaver merged 4 commits intogoogleapis:masterfrom
tseaver:7440-storage-blob_reload_passes_enc_headers
Conversation
Use it when reloading the instance.
Override to use the blob's '_encryption_key' attribute. Closes #7440.
googlebot
added
the
cla: yes
frankyn
reviewed
Mar 11, 2019
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
LGTM, this will allow a .reload() on an encrypted object. Though, I do want to ask if it's reasonable to apply _encryption_headers() check to even buckets given they're not valid.
Future us may ask why it's being used for buckets as well.
Contributor
Author
|
@frankyn The |
Contributor
|
Thanks @tseaver, could you add a comment near the method stating that it's primary use is for a Blob and the given use case? |
Contributor
Author
Contributor
Author
|
Unrelated Firestore failure is from a known-flaky systest, see #7130. |
crwilcox
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7440.