Remove Bucket.new_blob #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Updated Bucket.get_blob() and Bucket.delete_blob() to just take a string instead of string or Blob. Logic being that if the user already has a Blob, they can just call blob.delete() or blob._reload_properties() (more convenient method needed). Updated Bucket.delete_blobs() to check if each element in list of `blobs` is a string or a Blob. Updated Blob.delete() to call Bucket.delete_blob() with just a string and updated Blob.rename() to call Blob.delete() instead of re-implementing the mapping to Bucket.delete_blob(). Removed Test_Bucket.test_new_blob_existing, the last caller of Bucket.new_blob that sends a Blob instead of a string.
Opting to just use Blob() constructor where relevant.
dhermes
force-pushed
the
remove-new-blob
branch
from
c903460 to
d981af6
Compare
Contributor
|
LGTM |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 17, 2015
dhermes
added a commit
that referenced
this pull request
Mar 17, 2015
Fixing regression failure introduced in #725.
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * pin ipython version for python 3.9 because later versions dropped support for python 3.9 * pin pytest for python 3.7 * pin pytest for python 3.7 * pin pytest for python 3.7 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * pin ipython version for python 3.9 because later versions dropped support for python 3.9 * pin pytest for python 3.7 * pin pytest for python 3.7 * pin pytest for python 3.7 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
Source-Link: https://togithub.com/googleapis/synthtool/commit/fac8444edd5f5526e804c306b766a271772a3e2f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* docs: Add documentation for enums fix: Add context manager return types chore: Update gapic-generator-python to v1.8.1 PiperOrigin-RevId: 503210727 Source-Link: googleapis/googleapis@a391fd1 Source-Link: googleapis/googleapis-gen@0080f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…p/templates/python_library/.kokoro (#725) Source-Link: googleapis/synthtool@d0f51a0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Both dropped Python2 support in a minor release. grpcio does not declare 'python_requires'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not necessary,
Blob()constructor suffices.