Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 12, 2015

This decouples Bucket.exists() from Connection.get_bucket().

@tseaver This came up when I was to removing Connection.get_bucket(). I opted to just use connection.api_request instead of dealing with the potential cycle caused by importing storage.api anywhere but __init__.

As it turns out (as I mention in #632), this is a way to reduce the response payload for checking existence (unfortunately, the headers still are overwhelmingly verbose).

This decouples Bucket.exists() from Connection.get_bucket().

Relevant to googleapis#632.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6186059 on dhermes:use-fields-in-bucket-exists into d9e2156 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 13, 2015

LGTM

dhermes added a commit that referenced this pull request Mar 13, 2015
@dhermes dhermes merged commit ab642a3 into googleapis:master Mar 13, 2015
@dhermes dhermes deleted the use-fields-in-bucket-exists branch March 13, 2015 16:28
parthea pushed a commit that referenced this pull request Sep 18, 2025
This prepares the way for using the `query_and_wait` method built-in to the client library when available.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Towards #710 
🦕
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants