Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 12, 2015

See comments in #700 for context.

@tseaver I figured it would be easier to digest moving one method at a time instead of all 4 at once. Still remaining:

$ git grep -e '^    def' -- gcloud/storage/connection.py
gcloud/storage/connection.py:    def __init__(self, project, *args, **kwargs):
gcloud/storage/connection.py:    def build_api_url(self, path, query_params=None, api_base_url=None,
gcloud/storage/connection.py:    def _make_request(self, method, url, data=None, content_type=None,
gcloud/storage/connection.py:    def _do_request(self, method, url, headers, data):
gcloud/storage/connection.py:    def api_request(self, method, path, query_params=None,
gcloud/storage/connection.py:    def get_bucket(self, bucket_name):
gcloud/storage/connection.py:    def create_bucket(self, bucket_name):
gcloud/storage/connection.py:    def delete_bucket(self, bucket_name):
$ git log -1 --pretty=%H
9c783090ea81ec51c6752d24a3637da78a469631

NOTE: I re-ran the storage demo to make sure this worked and noticed the very first line was the license. Without the opening

# Welcome to the gCloud Storage Demo! (hit enter)

the demo is pretty tough to use. I can add the license back at the end of the file if necessary or even after # Welcome ... (/cc @jgeewax).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015
@dhermes dhermes force-pushed the storage-move-get-all-buckets-to-api branch from 9c78309 to 4f0c483 Compare March 12, 2015 19:33
@tseaver
Copy link
Contributor

tseaver commented Mar 12, 2015

LGTM. I would just move get_bucket, create_bucket, and delete_bucket in a single PR, though.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into 39627c0 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 12, 2015
STORAGE: Making Connection.get_all_buckets a standalone method.
@dhermes dhermes merged commit 7803d1a into googleapis:master Mar 12, 2015
@dhermes dhermes deleted the storage-move-get-all-buckets-to-api branch March 12, 2015 20:20
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 13, 2015
parthea pushed a commit that referenced this pull request Sep 18, 2025
…716)

Source-Link: googleapis/synthtool@280ddae
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:346ab2efb51649c5dde7756cbbdc60dd394852ba83b9bbffc292a63549f33c17

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* fix: updating testing, rest-only generation, & minor bug-fixes

* test: test async client generation

* fix: fixed reserved keyword bug, fixed bugs in gapic tests

* fix: reverted bug causing change to , refactored template tests

* fix: return type mismatch

* fix: reserved keyword issue in

* fix: replace bad regex checks with checks against field_pb type

* Update gapic/templates/noxfile.py.j2

Co-authored-by: Dov Shlachter <[email protected]>
Co-authored-by: Bu Sun Kim <[email protected]>
parthea added a commit that referenced this pull request Nov 24, 2025
* feat: Replace utcnow and utcfromtimestamp

These will be deprecated starting in Python 3.12.

Replaced:
- `datetime.datetime.utcnow()` with `datetime.datetime.now(tz=datetime.timezone.utc)`

- `datetime.utcfromtimestamp()` with `datetime.fromtimestamp(tz=datetime.timezone.utc)`

* docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow

* remove usage of  google.cloud.firestore_v1.rate_limiter.utcnow in code

* filter deprecation warning for google.cloud.firestore_v1.rate_limiter.utcnow

---------

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants