Adding back storage.lookup_bucket. #700

dhermes · 2015-03-12T07:02:40Z

This was originally removed in #588.

@tseaver I'd like to remove all the bucket functions from Connection and move them into api. WDYT?

Also it seems we'd eventually want to add a _require_connection as in datastore.api. It would be nice to come with a re-factor for re-usability (the Batch is the part which needs to be package specific).

FWIW: I came across this while trying to make implicit auth work in storage. Importing Connection in _implicit_environ creates a cycle, essentially because Connection imports Bucket.

This was originally removed in googleapis#588.

coveralls · 2015-03-12T07:05:12Z

Changes Unknown when pulling f50d036 on dhermes:add-back-storage-bucket-lookup into * on GoogleCloudPlatform:master*.

tseaver · 2015-03-12T16:46:10Z

Moving the bucket-related functions to storage.api SGTM.

tseaver · 2015-03-12T16:46:40Z

I'm not sure what the motivation is for re-adding the lookup_bucket() API.

dhermes · 2015-03-12T17:21:39Z

@tseaver We don't need to add it back, but in the discussion in #588 you asked that we add it back, so I was trying to get the ball rolling with the storage.api module with something simple.

See comments in googleapis#700 for context.

tseaver · 2015-03-12T19:19:43Z

facepalm I should have gone back to look at #588.

LGTM.

Adding back storage.lookup_bucket.

dhermes · 2015-03-12T19:23:40Z

Cool. I'll rebase #716 now.

See comments in googleapis#700 for context.

* feat(python-library): changes to docs job * feat(python-library): changes to docs job * migrate to Trampoline V2 * add docs-presubmit job * create docfx yaml files and upload them to another bucket * remove redundant envvars Source-Author: Takashi Matsuo <[email protected]> Source-Date: Wed Jul 29 16:15:18 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: f07cb4446192952f19be3056957f56d180586055 Source-Link: googleapis/synthtool@f07cb44 * Revert "feat(python-library): changes to docs job (#700)" This reverts commit f07cb4446192952f19be3056957f56d180586055. Source-Author: Bu Sun Kim <[email protected]> Source-Date: Wed Jul 29 17:33:57 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248 Source-Link: googleapis/synthtool@ee7506d * feat(python-library): changes to docs job * feat(python-library): changes to docs job * migrate to Trampoline V2 * add docs-presubmit job * create docfx yaml files and upload them to another bucket * remove redundant envvars * add a failing test first * fix TemplateSyntaxError: Missing end of comment tag * serving_path is not needed any more * use `raw` to make jinja happy Source-Author: Takashi Matsuo <[email protected]> Source-Date: Thu Jul 30 12:44:02 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214 Source-Link: googleapis/synthtool@5dfda56 * fix(python-library): add missing changes Source-Author: Takashi Matsuo <[email protected]> Source-Date: Thu Jul 30 18:26:35 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe Source-Link: googleapis/synthtool@39b527a * chore(py_library): add split_system_tests Source-Author: Takashi Matsuo <[email protected]> Source-Date: Fri Jul 31 16:17:13 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669 Source-Link: googleapis/synthtool@bfcdbe0 * chore(py_library): add some excludes in docs/conf.py This should fix build failures in python-bigquery. Example: googleapis/python-bigquery#205 * also add a comment Source-Author: Takashi Matsuo <[email protected]> Source-Date: Mon Aug 3 15:08:00 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 4f8f5dc24af79694887385015294e4dbb214c352 Source-Link: googleapis/synthtool@4f8f5dc Co-authored-by: Tres Seaver <[email protected]>

🤖 I have created a release \*beep\* \*boop\* --- ## [0.36.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.35.11...v0.36.0) (2020-11-14) ### Features * add rest transport generation for clients with optional transport flag ([#688](https://www.github.com/googleapis/gapic-generator-python/issues/688)) ([af59c2c](https://www.github.com/googleapis/gapic-generator-python/commit/af59c2c3c3d6b7e1f626c3fbc2c03f99ca31b4a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* feat: implement `OperationsRestAsyncTransport` to support long running operations (#700) * feat: Add OperationsRestAsyncTransport to support long running operations * update TODO comment * update TODO comment * address feedback * address feedback * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix mypy and lint issues * minor fix * add no cover * fix no cover tag * link coverage issue * silence coverage issue * fix statement name error * address PR feedback * address PR feedback * address PR comments --------- Co-authored-by: ohmayr <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: implement async client for LROs (#707) * feat: implement `AbstractOperationsAsyncClient` to support long running operations * remove coverage guards * address presubmit failures * fix coverage for cancel operation * tests cleanup * fix incorrect tests * file bugs * add auth import * address PR comments * address PR comments * fix unit tests and address more comments * disable retry parameter * add retry parameter * address PR comments --------- Co-authored-by: ohmayr <[email protected]> Co-authored-by: ohmayr <[email protected]> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * feat(python-library): changes to docs job * feat(python-library): changes to docs job * migrate to Trampoline V2 * add docs-presubmit job * create docfx yaml files and upload them to another bucket * remove redundant envvars Source-Author: Takashi Matsuo <[email protected]> Source-Date: Wed Jul 29 16:15:18 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: f07cb4446192952f19be3056957f56d180586055 Source-Link: googleapis/synthtool@f07cb44 * Revert "feat(python-library): changes to docs job (#700)" This reverts commit f07cb4446192952f19be3056957f56d180586055. Source-Author: Bu Sun Kim <[email protected]> Source-Date: Wed Jul 29 17:33:57 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248 Source-Link: googleapis/synthtool@ee7506d * feat(python-library): changes to docs job * feat(python-library): changes to docs job * migrate to Trampoline V2 * add docs-presubmit job * create docfx yaml files and upload them to another bucket * remove redundant envvars * add a failing test first * fix TemplateSyntaxError: Missing end of comment tag * serving_path is not needed any more * use `raw` to make jinja happy Source-Author: Takashi Matsuo <[email protected]> Source-Date: Thu Jul 30 12:44:02 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214 Source-Link: googleapis/synthtool@5dfda56 * fix(python-library): add missing changes Source-Author: Takashi Matsuo <[email protected]> Source-Date: Thu Jul 30 18:26:35 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe Source-Link: googleapis/synthtool@39b527a * chore(py_library): add split_system_tests Source-Author: Takashi Matsuo <[email protected]> Source-Date: Fri Jul 31 16:17:13 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669 Source-Link: googleapis/synthtool@bfcdbe0 * chore: patch docs/conf.py manually * docs: clean up docs/conf.py Co-authored-by: Takashi Matsuo <[email protected]>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * require proto-plus 1.22.2 for python 3.11 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Normally a unique namespace per test run is used to prevent different test runs from interfering with each other, but some tests are specifically for the default namespace. A discriminator is added to this test that allows us to narrow the test query to only entities created in the current test run. Fixes #700 Co-authored-by: Tres Seaver <[email protected]>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * require proto-plus 1.22.2 for python 3.11 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* fix: session object was never used in aiohttp request (#700) * fixup! fix: session object was never used in aiohttp request (#700) * fixup! fixup! fix: session object was never used in aiohttp request (#700) Co-authored-by: arithmetic1728 <[email protected]>

Adding back storage.lookup_bucket.

f50d036

This was originally removed in googleapis#588.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015

dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2015

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015

STORAGE: Making Connection.get_all_buckets a standalone method.

9c78309

See comments in googleapis#700 for context.

dhermes mentioned this pull request Mar 12, 2015

STORAGE: Making Connection.get_all_buckets a standalone method. #716

Merged

dhermes added a commit that referenced this pull request Mar 12, 2015

Merge pull request #700 from dhermes/add-back-storage-bucket-lookup

39627c0

Adding back storage.lookup_bucket.

dhermes merged commit 39627c0 into googleapis:master Mar 12, 2015

dhermes deleted the add-back-storage-bucket-lookup branch March 12, 2015 19:25

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015

STORAGE: Making Connection.get_all_buckets a standalone method.

4f0c483

See comments in googleapis#700 for context.

dhermes mentioned this pull request Mar 12, 2015

Upgrading version to 0.4.3. #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding back storage.lookup_bucket. #700

Adding back storage.lookup_bucket. #700

Uh oh!

dhermes commented Mar 12, 2015

Uh oh!

coveralls commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

dhermes commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

dhermes commented Mar 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Adding back storage.lookup_bucket. #700

Adding back storage.lookup_bucket. #700

Uh oh!

Conversation

dhermes commented Mar 12, 2015

Uh oh!

coveralls commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

dhermes commented Mar 12, 2015

Uh oh!

tseaver commented Mar 12, 2015

Uh oh!

dhermes commented Mar 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants