Skip to content

Skip signing tests for insufficient credentials#6917

Merged
crwilcox merged 3 commits intomasterfrom
skip-signing-test-for-gcloud
Dec 14, 2018
Merged

Skip signing tests for insufficient credentials#6917
crwilcox merged 3 commits intomasterfrom
skip-signing-test-for-gcloud

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2018
@crwilcox crwilcox requested a review from tseaver December 13, 2018 18:02
@crwilcox
Copy link
Copy Markdown
Contributor Author

Fix for internal bug: 113623918

Comment thread storage/tests/system.py Outdated
@unittest.skipUnless(
type(storage.Client()._credentials) is google.oauth2.service_account.credentials,
"Can only test signing with credentials capable of signing",
)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@crwilcox crwilcox requested a review from theacodes December 13, 2018 23:02
Comment thread storage/tests/system.py Outdated
@crwilcox crwilcox merged commit 20b7f38 into master Dec 14, 2018
@tseaver tseaver deleted the skip-signing-test-for-gcloud branch March 12, 2019 15:53
parthea pushed a commit that referenced this pull request Mar 9, 2026
* Skip signing tests for insufficient credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants