Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 9, 2015

Fixes #685.

NOTE: I did not remove the actual method from datastore.__init__ but easily could.

Here are the remaining uses of it.

In datastore:

$ git grep set_defaults 
gcloud/datastore/__init__.py:def set_defaults(dataset_id=None, connection=None):
gcloud/datastore/test___init__.py:class Test_set_defaults(unittest2.TestCase):
gcloud/datastore/test___init__.py:        from gcloud.datastore import set_defaults
gcloud/datastore/test___init__.py:        return set_defaults(dataset_id=dataset_id, connection=connection)

And storage:

gcloud/storage/__init__.py:def set_defaults(bucket=None, project=None, connection=None):
gcloud/storage/test___init__.py:class Test_set_defaults(unittest2.TestCase):
gcloud/storage/test___init__.py:        from gcloud.storage import set_defaults
gcloud/storage/test___init__.py:        return set_defaults(bucket=bucket, project=project,
regression/storage.py:storage.set_defaults()

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2015
@dhermes dhermes added api: datastore Issues related to the Datastore API. docs labels Mar 9, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 9, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Mar 9, 2015

@tseaver Sorry I just pushed another commit onto this also fixing #684.

I'm going to merge it as well (only a few lines and 100% in one file in one docstring). Let me know if there are issues.

dhermes added a commit that referenced this pull request Mar 9, 2015
Removing datastore.set_defaults() from all docs.
@dhermes dhermes merged commit 3c7316e into googleapis:master Mar 9, 2015
@dhermes dhermes deleted the fix-685 branch March 9, 2015 18:40
parthea pushed a commit that referenced this pull request Sep 18, 2025
* docs: set version: 2 in .readthedocs.yml

* move requirement file to python.requirements

* remove pip_install: true

* change build.image to build.os

* fix requirement docs name
parthea pushed a commit that referenced this pull request Nov 24, 2025
* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Add `OR` query support
docs: Improve the API documentation for the `Firestore.ListDocuments` RPC
docs: Minor documentation formatting and cleanup

PiperOrigin-RevId: 509631855

Source-Link: googleapis/googleapis@22bd888

Source-Link: googleapis/googleapis-gen@8b14516
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIxNDUxNjYxOWM0OGUxZGRhYmNlYzFhZWM1NWFjMDI1NzM2NDEwMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@e44dc0c
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d
parthea added a commit that referenced this pull request Nov 25, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Purge set_defaults() from all the docs

3 participants