Adding lazy loading support for dataset ID. #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
@tseaver I encountered your favorite, I first made a decorator def _lazy_property_deco(method):
return _LazyProperty(method.__name__, method)
class _DefaultsContainer(object):
@_lazy_property_deco
def dataset_id():
return _determine_default_dataset_id()but
Essentially the decorator might put something different in the class definition than the code indicates. If you prefer this approach we can add I kind of like / dislike that |
This was referenced Feb 19, 2015
Closed
Contributor
|
Shadowing a method with an instance attribute is a perfectly normal, acceptable practice: claiming it is wrong is insisting we ride the Python bike with training wheels on. Let's disable the warning. |
Still need to support connection (and eventually do the same
in storage).
Again verified only the lazy loading tests used implicit
behavior via
```diff
diff --git a/gcloud/datastore/_implicit_environ.py b/gcloud/datastore/_implicit_environ.py
index 6e61636..6d67be6 100644
--- a/gcloud/datastore/_implicit_environ.py
+++ b/gcloud/datastore/_implicit_environ.py
@@ -177,6 +177,10 @@ class _LazyProperty(object):
self._method = method
def __get__(self, obj, objtype):
+ class FooError(Exception):
+ pass
+ raise FooError
+
if obj is None or objtype is not _DefaultsContainer:
return self
```
The _DATASET_ENV_VAR_NAME moved from datastore.__init__ to datastore._implicit_environ.
- Ignoring method-hidden (PyLint) so we can decorate methods in a class. - Making _lazy_property_deco(deferred_callable) to decorate and re-use the function name and use it as a callable - Had to hack around Python2.6 differences in `staticmethod`
dhermes
force-pushed
the
lazy-loading-attempt-4
branch
from
4ce0753 to
b9d96ed
Compare
Contributor
Author
|
@tseaver PTAL. I just rebased this on top of #666. Some things which differ than the original PR:
|
|
Changes Unknown when pulling b9d96ed on dhermes:lazy-loading-attempt-4 into * on GoogleCloudPlatform:master*. |
Contributor
|
LGTM. |
dhermes
added a commit
that referenced
this pull request
Feb 19, 2015
Adding lazy loading support for dataset ID.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
* feat: added baseline model version used to generate the summary feat: added the platform of the virtual agent response messages PiperOrigin-RevId: 556882279 Source-Link: googleapis/googleapis@c8eccda Source-Link: googleapis/googleapis-gen@754eb33 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzU0ZWIzMzQwZDc2ZTZkYTY5ZjA4MTA0MWQ5N2YwMTgwMjJhNTVkYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
…)" (#667) This reverts commit ac098a747a6ee09d70479ae5b73479172ad6cd78.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(deps): require google-api-core>=1.34.0,>=2.11.0 * add gapic_version.py * update release-please-config.json Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #666 as diffbase.
Still need to support connection (and eventually do the same
in storage).
Again verified only the lazy loading tests used implicit
behavior via