Moving set_default_dataset_id into _implicit_environ. #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Closed
Contributor
|
15db084 LGTM |
dhermes
force-pushed
the
lazy-loading-attempt-3
branch
from
15db084 to
7d75636
Compare
Contributor
Author
|
Rebased on top of #665. Had to sniff out the redundant tests since the test moved wholesale. |
dhermes
added a commit
that referenced
this pull request
Feb 19, 2015
Moving set_default_dataset_id into _implicit_environ.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
parthea
added a commit
that referenced
this pull request
Nov 22, 2025
* chore(deps): update all dependencies * revert * increase timeouts * increase timeouts Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Features in the Ads templates require Python 3.7 or later.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* feat: optimize _GapicCallable * cleaned up metadata lines * chore: avoid type checks in error wrapper * Revert "chore: avoid type checks in error wrapper" This reverts commit c97a6365028f3f04d20f26aa1cc0e3131164f53e. * add default wrapped function * fixed decorator order * fixed spacing * fixed comment typo * fixed spacing * fixed spacing * removed unneeded helpers * use caching * improved metadata parsing * improved docstring * fixed logic * added benchmark test * update threshold * run benchmark in loop for testing * use verbose logs * Revert testing * used smaller value * changed threshold * removed link in comment * use list type for metadata * add types to docstring * fixed lint * convert to list at init time --------- Co-authored-by: Daniel Sanche <[email protected]> Co-authored-by: Daniel Sanche <[email protected]>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
In Cloud Datastore ancestor queries are intended to be strong by default (https://cloud.google.com/datastore/docs/concepts/structuring_for_strong_consistency) . In Cloud Firestore in Datastore mode, all queries should be strongly consistent by default (https://cloud.google.com/datastore/docs/upgrade-to-firestore). Fixes #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #665 as a diffbase