Storage: accomodate new back-end restriction on retention period.#6388
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Nov 5, 2018
tseaver:6368-storage-bucket_retention_property_setter_none
Merged
Storage: accomodate new back-end restriction on retention period.#6388tseaver merged 2 commits intogoogleapis:masterfrom tseaver:6368-storage-bucket_retention_property_setter_none
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:6368-storage-bucket_retention_property_setter_none
Conversation
googlebot
added
the
cla: yes
frankyn
reviewed
Nov 5, 2018
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Change LGTM. I'll approve after pending tests are complete.
Contributor
Author
|
@frankyn The pubsub failure is a Kokoro docker /networking barf (as well as being obviously unrelated to this PR). |
frankyn
approved these changes
Nov 5, 2018
tseaver
deleted the
6368-storage-bucket_retention_property_setter_none
branch
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6368.