Skip to content

Storage: ensure that 'method' for 'Blob.generate_signed_url' is uppercase.#6110

Merged
tseaver merged 1 commit intomasterfrom
6107-storage-create_signed_url-fix_method_case
Sep 26, 2018
Merged

Storage: ensure that 'method' for 'Blob.generate_signed_url' is uppercase.#6110
tseaver merged 1 commit intomasterfrom
6107-storage-create_signed_url-fix_method_case

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Sep 26, 2018

Closes #6107.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Sep 26, 2018
@tseaver tseaver requested a review from frankyn September 26, 2018 14:51
@tseaver tseaver requested a review from theacodes as a code owner September 26, 2018 14:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2018
frankyn
frankyn approved these changes Sep 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 8671f26 into master Sep 26, 2018
@tseaver tseaver deleted the 6107-storage-create_signed_url-fix_method_case branch September 26, 2018 20:05
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Ensure that 'method' for 'Blob.generate_signed_url' is uppercase. (#6110
e5a22aa 
)

Closes #6107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes Awaiting requested review from theacodes

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @frankyn @googlebot