Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 9, 2015

Fixes #152.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2015
@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

No py33 rule exists.

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

Also it looks like PEP8 1.6.0 (released February 6) decided E402 module level import not at top of file is important

@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

tox33 is covered by the generic [testenv] section.

#601 addresses the pep8 1.6.1 failures.

@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

Rebased after merging #601.

@dhermes
Copy link
Contributor

dhermes commented Feb 9, 2015

Ahh, I didn't know that. Cool! This means we could drop [testenv:py26] right?

LGTM pending Travis

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 760f44a on tseaver:152-add_py33_to_tox into * on GoogleCloudPlatform:master*.

We are now 2.6-compatible in the default environment.
@tseaver
Copy link
Contributor Author

tseaver commented Feb 9, 2015

I think the [testenv:py26] bits might be a fossil from some point in time where we needed to pin a dependency to a 2.6-compatible version (#284 maybe?). At any rate, it is now identical to [testenv], and so can go: (see a69c879).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a69c879 on tseaver:152-add_py33_to_tox into 6de4110 on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Feb 9, 2015
@tseaver tseaver merged commit ab0a587 into googleapis:master Feb 9, 2015
@tseaver tseaver deleted the 152-add_py33_to_tox branch February 9, 2015 23:17
parthea pushed a commit that referenced this pull request Aug 21, 2025
parthea pushed a commit that referenced this pull request Sep 16, 2025
parthea pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
fix(deps): require proto-plus >= 1.22.0
parthea added a commit that referenced this pull request Nov 25, 2025
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Nov 26, 2025
Migrate signBlob from iam.googleapis.com to iamcredentials.googleapis.com.

This API is deprecated and will be shutdown in one year.

This is used google.auth.iam.Signer.
Added a system_test to sanity check the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for py33 and py34 in tox

4 participants