Skip to content

PubSub: add geo-fencing support#5769

Merged
crwilcox merged 3 commits intogoogleapis:masterfrom
crwilcox:synth-pubsub
Aug 10, 2018
Merged

PubSub: add geo-fencing support#5769
crwilcox merged 3 commits intogoogleapis:masterfrom
crwilcox:synth-pubsub

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox commented Aug 7, 2018

Add support for storage location policy (geo-fencing) to Pub/Sub by regenerating v1 endpoint

@crwilcox crwilcox requested a review from theacodes as a code owner August 7, 2018 20:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2018
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Aug 7, 2018
@tseaver tseaver changed the title [PubSub] Add support for storage location policy (geo-fencing) PubSub: add geo-fencing support Aug 7, 2018
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Aug 7, 2018

@crwilcox lint failures:

nox > Running session lint
nox > /usr/local/bin/python3.6 -m virtualenv /var/code/gcp/.nox/lint -p python3.6
nox > chdir /var/code/gcp/pubsub
nox > pip install --upgrade flake8 ../api_core ../core
nox > pip install --upgrade .
nox > flake8 google tests
google/__init__.py:20:55: W292 no newline at end of file
google/cloud/__init__.py:20:55: W292 no newline at end of file
google/cloud/pubsub_v1/__init__.py:34:2: W292 no newline at end of file
nox > Command flake8 google tests failed with exit code 1
nox > Session lint failed.

@tseaver tseaver added the codegen label Aug 8, 2018
@JustinBeckwith
Copy link
Copy Markdown
Contributor

👋 Not sure why this is assigned to me :)

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Aug 8, 2018

@JustinBeckwith Heh, I don't even know what "assigned" means for a PR (vs. "review requested").

@crwilcox
Copy link
Copy Markdown
Contributor Author

crwilcox commented Aug 8, 2018

Looks like docs are not building. I will look at that and update this in a bit.

@crwilcox crwilcox merged commit 371333a into googleapis:master Aug 10, 2018
AVaksman pushed a commit to AVaksman/google-cloud-python that referenced this pull request Aug 16, 2018
* Add support for storage location policy (geo-fencing) to Pub/Sub by regenerating v1 endpoint
parthea pushed a commit that referenced this pull request Mar 2, 2026
* Add support for storage location policy (geo-fencing) to Pub/Sub by regenerating v1 endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants