Fixing flaky datastore queries in regression tests. #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 019e3dd on dhermes:fix-flaky-datastore-query into * on GoogleCloudPlatform:master*. |
Contributor
Author
|
I should also note that this exposed (and fixed) a bug in >>> from gcloud import datastore
>>> datastore.set_default_dataset_id('foo')
>>> key = datastore.Key('Foo', parent=datastore.Key('Bar', 1))
>>> key
<Key[{'kind': 'Bar', 'id': 1}, {'kind': 'Foo'}], dataset=foo>
>>> key._clone()
<Key[{'kind': 'Bar', 'id': 1}, {'kind': 'Bar', 'id': 1}, {'kind': 'Foo'}], dataset=foo> |
Contributor
|
LGTM. Nice to catch that |
Using an ancestor in queries to ensure consistency. See googleapis#562 for context.
dhermes
force-pushed
the
fix-flaky-datastore-query
branch
from
019e3dd to
0489094
Compare
Contributor
Author
|
Rebased, now merging. |
dhermes
added a commit
that referenced
this pull request
Jan 27, 2015
Fixing flaky datastore queries in regression tests.
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* changes without context
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
* chore(python): remove one remaining extra bash line (#565)
To avoid generating bogus PRs
Co-authored-by: Jeffrey Rennie <[email protected]>
Source-Author: Carlos de la Guardia <[email protected]>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…1; make 'features' a positional param for annotate_video in betas (#31) * Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * chore(python): create thread_safety doc (#517) This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 5 10:06:52 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef Source-Link: googleapis/synthtool@09c4846 * chore(python): remove extra #!/bin/bash (#538) Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 12 09:51:12 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 7482e79a82e353248769d819788adc1213e8c207 Source-Link: googleapis/synthtool@7482e79 * chore!: enable gapicv2 for monitoring/v3 API This introduces the following breakages upon code regeneration, which are due to the `TimeSeriesQueryLanguageCondition` type being removed from `alert.proto` in a preceding change. ``` [ERROR] 6011: com.google.monitoring.v3.AlertPolicy$Condition: Field CONDITION_TIME_SERIES_QUERY_LANGUAGE_FIELD_NUMBER has been removed, but it was previously a constant [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder clearConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder getConditionTimeSeriesQueryLanguageBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder mergeConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder)' has been removed [ERROR] 6001: com.google.monitoring.v3.AlertPolicy$Condition$ConditionCase: Removed field CONDITION_TIME_SERIES_QUERY_LANGUAGE [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition removed [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder removed [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed ``` Committer: @miraleung PiperOrigin-RevId: 311581003 Source-Author: Google APIs <[email protected]> Source-Date: Thu May 14 12:13:51 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 123873dc7e2be35252d172205f67a375e70e9747 Source-Link: googleapis/googleapis@123873d * fix: restore GAPIC v2 retry configs Restores GAPIC v2 retry config overrides that were mistakenly removed during migration. PiperOrigin-RevId: 312088359 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 08:57:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c Source-Link: googleapis/googleapis@5a90d46 * feat(v1p3beta1): added support for streaming automl action recognition. PiperOrigin-RevId: 312101156 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 10:04:40 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: d1a9f02fd4fb263bae0383b4a5af0bbef33753d6 Source-Link: googleapis/googleapis@d1a9f02 * fix: point artman at gapic v1 for monitoring/v3 API Committer: @miraleung PiperOrigin-RevId: 312104480 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 10:19:39 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e94ad376529fabdfd2fce00407926a0cefd38b9e Source-Link: googleapis/googleapis@e94ad37 * Dialogflow weekly v2 library update: - Minor comment updates. PiperOrigin-RevId: 312123588 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 11:49:18 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cd3ce2651c3921670217e664303976cdf76e9fe2 Source-Link: googleapis/googleapis@cd3ce26 * chore(python): remove one remaining extra bash line (#565) To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb * Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings. PiperOrigin-RevId: 312689208 Source-Author: Google APIs <[email protected]> Source-Date: Thu May 21 10:00:47 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f Source-Link: googleapis/googleapis@dec3204 * bazel: update protobuf, rules_go, gazelle, and gapic-generator-go versions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 PiperOrigin-RevId: 313460921 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 14:10:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c4e37010d74071851ff24121f522e802231ac86e Source-Link: googleapis/googleapis@c4e3701 * Use correct resource type for DetachSubscriptionRequest PiperOrigin-RevId: 313488995 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 16:45:32 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: eafa840ceec23b44a5c21670288107c661252711 Source-Link: googleapis/googleapis@eafa840 * docs: update python docs template (#576) * docs: update python docs template * sphinx change Source-Author: kolea2 <[email protected]> Source-Date: Wed May 27 20:44:34 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec Source-Link: googleapis/synthtool@71b8a27 * feat: add templates for python samples projects (#506) These templates will be used for templates in python-docs-samples and in Python client libraries. The README generation code is a modified version of https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen. Co-authored-by: Kurtis Van Gent <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:39:58 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e Source-Link: googleapis/synthtool@ffe1040 * chore: update default ignores for Python libraries (#586) Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:43:37 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca Source-Link: googleapis/synthtool@e99975b * feat: allow custom python versions in noxfile (#585) Libraries on the microgenerator support a smaller range of Python versions (3.6+). Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 18:22:04 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e Source-Link: googleapis/synthtool@4e1d2cb * docs: fix docs Co-authored-by: Bu Sun Kim <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
) Source-Link: googleapis/synthtool@0c7b033 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Dec 20, 2024
* chore(python): remove one remaining extra bash line (#565) To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb * fix: fix noxfile Co-authored-by: Bu Sun Kim <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Jan 10, 2025
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
These system tests rely on a public dataset table: bigquery-public-data.new_york_citibike.citibike_stations The schema of this table recently changed, and a formerly int64 column was switched to a string type. This PR updates that by switching from the affected column to another column less likely to suffer type conversions in the future (num_bikes_available). Fixes: googleapis/python-bigquery-storage#558 Fixes: googleapis/python-bigquery-storage#559 Fixes: googleapis/python-bigquery-storage#560 Fixes: googleapis/python-bigquery-storage#561 Fixes: googleapis/python-bigquery-storage#562 Fixes: googleapis/python-bigquery-storage#563
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
These system tests rely on a public dataset table: bigquery-public-data.new_york_citibike.citibike_stations The schema of this table recently changed, and a formerly int64 column was switched to a string type. This PR updates that by switching from the affected column to another column less likely to suffer type conversions in the future (num_bikes_available). Fixes: googleapis/python-bigquery-storage#558 Fixes: googleapis/python-bigquery-storage#559 Fixes: googleapis/python-bigquery-storage#560 Fixes: googleapis/python-bigquery-storage#561 Fixes: googleapis/python-bigquery-storage#562 Fixes: googleapis/python-bigquery-storage#563
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: googleapis/synthtool@71a7297 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* chore: Update gapic-generator-python to 1.24.0 PiperOrigin-RevId: 747419463 Source-Link: googleapis/googleapis@340579b Source-Link: googleapis/googleapis-gen@e8997ec Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTg5OTdlYzUxMzZlY2I2ZWQ5YTk2OWE0YzJmMTNiM2FiNmExN2MxMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Mariatta Wijaya <[email protected]>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Had mistakenly written that non-strict behavior occurs when `strict_read` or `strict_write` are `True`, when it should have said when they are `False`. Closes #563. Co-authored-by: Andrew Gorcester <[email protected]>
parthea
added a commit
that referenced
this pull request
Nov 25, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an ancestor in queries to ensure consistency.
See #562 for context.