Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 16, 2015

Requires oauth2client>=1.4.6 (@tseaver should I put this in setup.py?)

Also had to update storage/acl.py due to a change in
PyLint that didn't like self as a kwarg to a str instance
method

Fixes #537

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2015
@tseaver
Copy link
Contributor

tseaver commented Jan 16, 2015

Given that we import oauth2client.crypt unconditionally, yes we need to bound it in install_requires.

BTW, 1.4.6 seems like an odd version number for a new feature (rather than a bug fix we need).

Requires oauth2client>=1.4.6.

Also had to update storage/acl.py due to a change in
PyLint that didn't like `self` as a kwarg to a str instance
method
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a17cafe on dhermes:fix-537 into edfd5e2 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 16, 2015

@tseaver It's a bit funky how OpenSSL is a "dependency" of oauth2client. The method will always be defined, but if OpenSSL is not installed then the method is defined as:

  def pkcs12_key_as_pem(*args, **kwargs):
    raise NotImplementedError('pkcs12_key_as_pem requires OpenSSL.')

For our library, the only place we need OpenSSL is the line in _get_pem_key in this PR. So if we decided not to support .p12 keys, we could totally ditch this. (It's unclear what Google's preference is since it's still possible to download a JSON/PEM key and a .p12 key.)

RE: The odd release number, this was just added in googleapis/oauth2client#115

@tseaver
Copy link
Contributor

tseaver commented Jan 16, 2015

@craigcitro @dhermes the setuptools way to express "optional" dependencies is via extras. I don't know if that would clarify anything for oauth2client.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 16, 2015

I am a n00b there and happy to learn. This extra will be for oauth2client, not for us, so may not be blocking for this PR. Am I missing something?

@tseaver
Copy link
Contributor

tseaver commented Jan 16, 2015

Nothing blocking us now. If oauth2client releases a version that has an [openssl] extra, we would need to adjust our dependency to pick that up.

LGTM to merge.

dhermes added a commit that referenced this pull request Jan 16, 2015
Removing hard dependency on PyOpenSSL.
@dhermes dhermes merged commit 1bfa469 into googleapis:master Jan 16, 2015
@dhermes dhermes deleted the fix-537 branch January 17, 2015 00:04
parthea pushed a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* chore: Update gapic-generator-python to v1.11.7

PiperOrigin-RevId: 573230664

Source-Link: googleapis/googleapis@93beed3

Source-Link: googleapis/googleapis-gen@f4a4eda
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.11.8

PiperOrigin-RevId: 574178735

Source-Link: googleapis/googleapis@7307199

Source-Link: googleapis/googleapis-gen@ce3af21
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.11.9

PiperOrigin-RevId: 574520922

Source-Link: googleapis/googleapis@5183984

Source-Link: googleapis/googleapis-gen@a59af19
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5YWYxOWQ0YWM2NTA5ZmFlZGYxY2MzOTAyOTE0MWI2YTViODk2OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update index.rst; remove unused files

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Nov 24, 2025
…lates/python_library/.kokoro (#559)

Source-Link: googleapis/synthtool@9367caa
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f155882785883336b4468d5218db737bb1d10c9cea7cb62219ad16fe248c03c

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: Update gapic-generator-python to v1.18.5

PiperOrigin-RevId: 661268868

Source-Link: googleapis/googleapis@f7d214c

Source-Link: googleapis/googleapis-gen@79a8411
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzlhODQxMWJiZGIyNWE5ODNmYTNhYWU4YzBlMTQzMjdkZjEyOWY5NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Author: Daniel Sanche <[email protected]>
Source-Date: Wed Oct 14 08:00:06 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 477764cc4ee6db346d3febef2bb1ea0abf27de52
Source-Link: googleapis/synthtool@477764c

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing hard dependency on PyOpenSSL

4 participants