Adding api.delete() and removing Key.delete(). #527

dhermes · 2015-01-09T02:31:56Z

Also:

Changing api.get() back to accept only keys and
returns only a list (a lot of headache for not much
gain).
Factored out behavior to extract shared dataset_id from
a set of keys into _get_dataset_id_from_keys().
Updated docstrings and other tests that rely on changed /
removed methods.

See #518 for some context.

coveralls · 2015-01-09T02:34:00Z

Coverage remained the same when pulling c5a634f on dhermes:add-delete-method into 0525530 on GoogleCloudPlatform:master.

dhermes · 2015-01-09T02:35:06Z

@tseaver I took a stab at testing / integrating the implementation from your comment.

If you already wrote this up, feel free to close.

Also, viewing _get_dataset_id_from_keys in light of #447, we should remove dataset_id from the Batch constructor and instead rely on Batch.put(), Batch.add_auto_id_entity(), and Batch.delete() to set / check the dataset ID. (This also means Batch.begin() has to move outside of __enter__.)

tseaver · 2015-01-12T21:24:28Z

LGTM.

Also: - Changing api.get() back to accept only `keys` and returns only a list (a lot of headache for not much gain). - Factored out behavior to extract shared dataset_id from a set of keys into _get_dataset_id_from_keys(). - Updated docstrings and other tests that rely on changed / removed methods. See googleapis#518 for some context.

tseaver · 2015-01-12T21:57:33Z

Merge broken?

======================================================================
ERROR: test_delete_existing_batch (gcloud.datastore.test_api.Test_delete_function)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/GoogleCloudPlatform/gcloud-python/gcloud/datastore/test_api.py", line 322, in test_delete_existing_batch
connection._deleted,
AttributeError: '_Connection' object has no attribute '_deleted'
======================================================================
ERROR: test_delete_implicit_connection (gcloud.datastore.test_api.Test_delete_function)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/GoogleCloudPlatform/gcloud-python/gcloud/datastore/test_api.py", line 350, in test_delete_implicit_connection
connection._deleted,
AttributeError: '_Connection' object has no attribute '_deleted'

Behavior of test_batch._Connection changed in googleapis#524.

dhermes · 2015-01-12T22:01:08Z

No, merge was fine, just changes to test_batch._Connection from #524 broke my tests (rightfully so).

I fixed in 2908d6f.

coveralls · 2015-01-12T22:02:38Z

Coverage remained the same when pulling 2908d6f on dhermes:add-delete-method into 51c1069 on GoogleCloudPlatform:master.

Adding api.delete() and removing Key.delete().

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.11.3 PiperOrigin-RevId: 546899192 Source-Link: googleapis/googleapis@e6b1691 Source-Link: googleapis/googleapis-gen@0b3917c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIzOTE3YzQyMWNiZGE3ZmNiNjcwOTJlMTZjMzNmM2VhNDZmNGJjNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: add presubmit for linting setup.py * fix duplicate implicit target name in README.rst * add action to lint setup.py * style * add new line

* feat: optimize _GapicCallable * cleaned up metadata lines * chore: avoid type checks in error wrapper * Revert "chore: avoid type checks in error wrapper" This reverts commit c97a6365028f3f04d20f26aa1cc0e3131164f53e. * add default wrapped function * fixed decorator order * fixed spacing * fixed comment typo * fixed spacing * fixed spacing * removed unneeded helpers * use caching * improved metadata parsing * improved docstring * fixed logic * added benchmark test * update threshold * run benchmark in loop for testing * use verbose logs * Revert testing * used smaller value * changed threshold * removed link in comment

Source-Link: googleapis/synthtool@d895aec Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:98f3afd11308259de6e828e37376d18867fd321aba07826e29e4f8d9cab56bad Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…es (#527) Fixes #526

Follow up to #519

dhermes added the api: datastore Issues related to the Datastore API. label Jan 9, 2015

dhermes mentioned this pull request Jan 12, 2015

Factor out mutation-setting logic from 'Connection'. #524

Merged

dhermes force-pushed the add-delete-method branch from c5a634f to 697d50c Compare January 12, 2015 21:39

dhermes force-pushed the add-delete-method branch from 697d50c to ac3f9b1 Compare January 12, 2015 21:40

dhermes mentioned this pull request Jan 12, 2015

Decouple Transaction from Connection #514

Closed

8 tasks

Updating api.delete() test to rely on new Batch behavior.

2908d6f

Behavior of test_batch._Connection changed in googleapis#524.

dhermes added a commit that referenced this pull request Jan 12, 2015

Merge pull request #527 from dhermes/add-delete-method

dcb73d3

Adding api.delete() and removing Key.delete().

dhermes merged commit dcb73d3 into googleapis:master Jan 12, 2015

dhermes deleted the add-delete-method branch January 12, 2015 22:04

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore: test minimum dependencies in python 3.7 (#527)

78db2b6

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-asset to v3.15.0 (#527)

19db36b

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update dependency pytest to v7.2.0 (#527)

f2dd77d

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update dependency pytest to v7.2.0 (#527)

5e28d79

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore(main): release 2.7.0 (#527)

b470274

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: paged code and templates are no longer message centric (#527)

8f0ab5e

parthea added a commit that referenced this pull request Nov 24, 2025

chore: add presubmit for linting setup.py (#527)

7cbf4ce

* chore: add presubmit for linting setup.py * fix duplicate implicit target name in README.rst * add action to lint setup.py * style * add new line

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: make sure keys_only ordered multiquery returns keys not entiti…

0803d13

…es (#527) Fixes #526

parthea pushed a commit that referenced this pull request Nov 26, 2025

test: add more tests for service account quota projects (#527)

c8a7e30

Follow up to #519

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding api.delete() and removing Key.delete(). #527

Adding api.delete() and removing Key.delete(). #527

Uh oh!

dhermes commented Jan 9, 2015

Uh oh!

coveralls commented Jan 9, 2015

Uh oh!

dhermes commented Jan 9, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Adding api.delete() and removing Key.delete(). #527

Adding api.delete() and removing Key.delete(). #527

Uh oh!

Conversation

dhermes commented Jan 9, 2015

Uh oh!

coveralls commented Jan 9, 2015

Uh oh!

dhermes commented Jan 9, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants