Fixup datastore demo to match API changes #504

tseaver · 2015-01-07T22:20:05Z

No description provided.

dhermes · 2015-01-07T22:23:04Z

More of favorite:

./gcloud/datastore/demo/demo.py:45:23: E261 at least two spaces before inline comment
./gcloud/datastore/demo/demo.py:51:5: E129 visually indented line with same indent as next logical line

Is there an issue running tox -e lint locally?

gcloud/datastore/demo/demo.py

tseaver · 2015-01-07T22:32:53Z

I didn't run lint because I was touching only demo code, and lint has been extra slow. ec034e1 should fix it.

dhermes · 2015-01-07T22:35:05Z

If you set

export GCLOUD_REMOTE_FOR_LINT="upstream"
export GCLOUD_BRANCH_FOR_LINT="master"

as suggested in CONTRIBUTING it is much faster.

coveralls · 2015-01-07T22:41:16Z

Changes Unknown when pulling ec034e1 on tseaver:fixup-demo-20150107 into * on GoogleCloudPlatform:master*.

tseaver · 2015-01-07T22:45:37Z

Re: speeding up lint via env vars -- I've seen false positives there, so left them always upset. It has slowed down: in fact, I think I've seen evidence that it is running twice (reporting duplicate errors for the same line numbers, but in groups).

dhermes · 2015-01-07T22:49:21Z

LGTM

The false positives are few and far between, but it's up to you to weight the speed-up against the occasional false positive.

RE: "Duplicates". That's not new. It comes from pylint itself recursively going into dependencies and some modules are a dependency for more than one module. If we weren't using different configs for different filesets, and just running pylint without specifying filenames, I think it would go away.

Fixup datastore demo to match API changes

* chore: delete handwritten samples * merge fix? * moar fix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update samples/snippets/README.rst --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Dan Lee <[email protected]>

Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

…cp/templates/python_library/.kokoro (#504) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

add argument description for restore() method

…504) Source-Link: googleapis/synthtool@395d53a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@25083af Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@352b9d4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: delete handwritten samples * merge fix? * moar fix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update samples/snippets/README.rst --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Dan Lee <[email protected]>

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Towards #367 🦕

* chore(python): update dependencies in .kokoro/docker/docs Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 * See https://github.com/googleapis/synthtool/pull/2033/files --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Closes #504 Co-authored-by: ndavydovdev <[email protected]>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.14.2](https://www.github.com/googleapis/google-auth-library-python/compare/v1.14.1...v1.14.2) (2020-05-07) ### Bug Fixes * support string type response.data ([#504](https://www.github.com/googleapis/google-auth-library-python/issues/504)) ([9b7228e](https://www.github.com/googleapis/google-auth-library-python/commit/9b7228ec849e311bcb4007ad3e23cf2f1e54a721)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

dhermes reviewed Jan 7, 2015
View reviewed changes

gcloud/datastore/demo/demo.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 2 commits January 7, 2015 17:27

Speed up keyboard delay.

23eb141

Accomodate API changes.

6dcd06b

dhermes reviewed Jan 7, 2015
View reviewed changes

gcloud/datastore/demo/demo.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Moar chixen bonez.

ec034e1

tseaver added a commit that referenced this pull request Jan 7, 2015

Merge pull request #504 from tseaver/fixup-demo-20150107

8caac14

Fixup datastore demo to match API changes

tseaver merged commit 8caac14 into googleapis:master Jan 7, 2015

tseaver deleted the fixup-demo-20150107 branch January 7, 2015 22:52

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update all dependencies (#504)

5695965

parthea pushed a commit that referenced this pull request Oct 21, 2023

fix: add missing argument description (#504)

a76e419

add argument description for restore() method

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update all dependencies (#504)

2c538e4

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update all dependencies (#504)

ae2a2a4

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: use contextvars.ConvextVar instead of threading.local in Python 3

96975cd

Closes #504 Co-authored-by: ndavydovdev <[email protected]>

parthea pushed a commit that referenced this pull request Nov 26, 2025

fix: support string type response.data (#504)

f859981

Fixup datastore demo to match API changes #504

Fixup datastore demo to match API changes #504

Uh oh!

Conversation

tseaver commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

coveralls commented Jan 7, 2015

Uh oh!

tseaver commented Jan 7, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants