-
Notifications
You must be signed in to change notification settings - Fork 1.6k
477: Prepare to remove dataset #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gcloud/datastore/key.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Also, make both it and '_require_connection' take the passed object, and test explicitly against None.
Will replace 'set_default_dataset'.
Contributor
Author
|
Sorry for the clash: I was trying to nibble at the edges to remove more usage of |
Contributor
|
No worries. What do you want to do? RE: #500 |
Contributor
Author
|
Why don't we go ahead with #500: we can eyeball / cherrypick this one as needed. |
Contributor
|
Thanks |
tseaver
added a commit
that referenced
this pull request
Jan 7, 2015
Cherry pick cleanups from #499.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…elete a SavedQuery (#499) * Change the comment of BatchGetEffectiveIamPolicies to be more accurate. * feat: Adds code examples to create, get, list, update and delete a SavedQuery. * feat: Adds code examples to create, get, list, update and delete a SavedQuery. * Update samples/snippets/quickstart_create_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_create_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_create_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_update_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_list_saved_queries_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_update_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_update_saved_query_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_get_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_create_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_create_saved_query_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_create_saved_query_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_delete_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_delete_saved_query_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_get_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_get_saved_query.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_get_saved_query_test.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_list_saved_queries.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_list_saved_queries.py Co-authored-by: Dan Lee <[email protected]> * Update samples/snippets/quickstart_list_saved_queries_test.py Co-authored-by: Dan Lee <[email protected]> * feat: Adds code examples to create, get, list, update and delete a SavedQuery. * feat: Adds code examples to create, get, list, update and delete a SavedQuery. * Update samples/snippets/quickstart_create_saved_query.py Co-authored-by: Dan Lee <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
🤖 I have created a release *beep* *boop* --- ### [0.17.4](googleapis/python-bigquery-pandas@v0.17.3...v0.17.4) (2022-03-14) ### Bug Fixes * avoid deprecated "out-of-band" authentication flow ([#500](googleapis/python-bigquery-pandas#500)) ([4758e3a](googleapis/python-bigquery-pandas@4758e3a)) * correctly transform query job timeout configuration and exceptions ([#492](googleapis/python-bigquery-pandas#492)) ([d8c3900](googleapis/python-bigquery-pandas@d8c3900)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* updated CHANGELOG.md [ci skip] * updated setup.py Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* Sets cache support to false, removes upper req limit * fix: Sets cache support to false, removes upper req limit * Removes OBE comments regarding max version number
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-pubsub</summary> ### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#​2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09) [Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0) ##### Features - retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#​607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40)) - return singleton success future for exactly-once methods in Message ([#​608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0)) ##### Bug Fixes - **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#​600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e)) - **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
parthea
pushed a commit
that referenced
this pull request
Nov 25, 2025
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-pubsub</summary> ### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#​2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09) [Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0) ##### Features - retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#​607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40)) - return singleton success future for exactly-once methods in Message ([#​608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0)) ##### Bug Fixes - **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#​600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e)) - **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key.__init__uses implicit dataset ID when appropriate.Toward #477, step 8.