Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 7, 2015

  • Don't document use of 'Dataset' or its factory methods.
  • Ensure that we have an implicit dataset ID.
  • Ensure that Key.__init__ uses implicit dataset ID when appropriate.

Toward #477, step 8.

@tseaver tseaver changed the title 477 prepare to remove dataset 477: Prepare to remove dataset Jan 7, 2015
@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

@tseaver I'm also working on this (I am the assignee on #477, sorry for not communicating that I was working on it)

This comment was marked as spam.

Also, make both it and '_require_connection' take the passed object,
and test explicitly against None.
Will replace 'set_default_dataset'.
@tseaver
Copy link
Contributor Author

tseaver commented Jan 7, 2015

Sorry for the clash: I was trying to nibble at the edges to remove more usage of Dataset before we actually removed the module.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

No worries. What do you want to do? RE: #500

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8baf341 on tseaver:477-prepare_to_remove_dataset into f176098 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Jan 7, 2015

Why don't we go ahead with #500: we can eyeball / cherrypick this one as needed.

@tseaver tseaver closed this Jan 7, 2015
@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

Thanks

@tseaver tseaver deleted the 477-prepare_to_remove_dataset branch January 7, 2015 20:34
tseaver added a commit that referenced this pull request Jan 7, 2015
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
…elete a SavedQuery (#499)

* Change the comment of BatchGetEffectiveIamPolicies to be more accurate.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_update_saved_query_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_delete_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_delete_saved_query_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_get_saved_query_test.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <[email protected]>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <[email protected]>

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <[email protected]>
parthea pushed a commit that referenced this pull request Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 16, 2025
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 18, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
* updated CHANGELOG.md [ci skip]

* updated setup.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Sets cache support to false, removes upper req limit

* fix: Sets cache support to false, removes upper req limit

* Removes OBE comments regarding max version number
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/compatibility-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/confidence-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-pubsub</summary>

### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#&#8203;2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09)

[Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0)

##### Features

-   retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#&#8203;607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40))
-   return singleton success future for exactly-once methods in Message ([#&#8203;608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0))

##### Bug Fixes

-   **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#&#8203;600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))
-   **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
parthea pushed a commit that referenced this pull request Nov 25, 2025
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/compatibility-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/confidence-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-pubsub</summary>

### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#&#8203;2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09)

[Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0)

##### Features

-   retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#&#8203;607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40))
-   return singleton success future for exactly-once methods in Message ([#&#8203;608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0))

##### Bug Fixes

-   **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#&#8203;600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))
-   **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants