Skip to content

Revert "Do not use easily-misread glyphs in Firestore auto-IDs." #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chemelnucfin merged 3 commits into from
Dec 13, 2017
Merged

Revert "Do not use easily-misread glyphs in Firestore auto-IDs." #4589

chemelnucfin merged 3 commits into from
Dec 13, 2017

Conversation

@chemelnucfin
Copy link
Contributor

@chemelnucfin chemelnucfin commented Dec 13, 2017

Reverts #4107

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2017
@chemelnucfin chemelnucfin merged commit 642bbed into master Dec 13, 2017
@dhermes dhermes deleted the revert-4107-autoid-no-confusing-chars branch December 13, 2017 23:22
parthea pushed a commit that referenced this pull request Nov 24, 2025
@chemelnucfin
Revert "Do not use easily-misread glyphs in Firestore auto-IDs." (#4589)
023d5f0 
* Revert "Removing redundant constant. (#4588)"

This reverts commit be0493b.

* Revert "Spanner: Changed _rows to list (#4583)"

This reverts commit 0e4fc30.

* Revert "Do not use easily-misread glyphs in Firestore auto-IDs. (#4107)"

This reverts commit 8715da91470904deeed368ac7064dee32c639779.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chemelnucfin @googlebot