-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix regression test failure introduced in PR #449. #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tseaver
merged 1 commit into
googleapis:master
from
tseaver:449-fix_transaction_borked_in_449
Dec 19, 2014
Merged
Fix regression test failure introduced in PR #449. #452
tseaver
merged 1 commit into
googleapis:master
from
tseaver:449-fix_transaction_borked_in_449
Dec 19, 2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 3d14518 on tseaver:449-fix_transaction_borked_in_449 into * on GoogleCloudPlatform:master*. |
tseaver
added a commit
that referenced
this pull request
Dec 19, 2014
Fix regression test failure introduced in PR #449.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
* fix: remove SpeechHelpers from STT V2 client library * chore: update post processing script * chore: clean up post processing script Co-authored-by: Nitsan Shai <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
* fix: remove SpeechHelpers from STT V2 client library * chore: update post processing script * chore: clean up post processing script Co-authored-by: Nitsan Shai <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
* fix: remove SpeechHelpers from STT V2 client library * chore: update post processing script * chore: clean up post processing script Co-authored-by: Nitsan Shai <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
* fix: remove SpeechHelpers from STT V2 client library * chore: update post processing script * chore: clean up post processing script Co-authored-by: Nitsan Shai <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
…cp/templates/python_library/.kokoro (#452) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
…452) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
* chore: exclude requirements.txt file from renovate-bot Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6 * update constraints files * fix(deps): require protobuf 3.20.2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude templated readme * fix typo Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: googleapis/synthtool@25083af Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Oct 22, 2023
* fix: remove SpeechHelpers from STT V2 client library * chore: update post processing script * chore: clean up post processing script Co-authored-by: Nitsan Shai <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
A fairly standard use case is to precompose a query and then call methods like `fetch` or `count` as needed. In this case you might call `count()` on a query with an `order_by` option. Previously, if the query was also a multiquery, this could cause an error as we'd be trying to sort on the client side using data that wasn't there, because we'd converted the query to `keys_only` for purposes of getting a count. This fixes that problem by stripping `order_by` from the query options when `count()` is called. Fixes #447
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.