Skip to content

fix api endpoints for storage upload/download #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silvolu merged 1 commit into from
Dec 12, 2014
Merged

fix api endpoints for storage upload/download #414

silvolu merged 1 commit into from
Dec 12, 2014

Conversation

@silvolu
Copy link
Contributor

@silvolu silvolu commented Dec 11, 2014

No description provided.

silvolu
silvolu reviewed Dec 11, 2014
View reviewed changes
gcloud/storage/test_key.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

coveralls commented Dec 11, 2014

Coverage Status

Changes Unknown when pulling f0395d2 on silvolu:fix-storage-requests-urls into * on GoogleCloudPlatform:master*.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 12, 2014

Given that upload/download are currently broken, I'd like to merge this. Any objections?

@tseaver
Copy link
Contributor

tseaver commented Dec 12, 2014

Nope.

@tseaver
Copy link
Contributor

tseaver commented Dec 12, 2014

I don't understand why the regression tests were passing on my machine on the branch before the merge, but failing afterward.

silvolu added a commit that referenced this pull request Dec 12, 2014
@silvolu
Merge pull request #414 from silvolu/fix-storage-requests-urls
ce828ac 
fix api endpoints for storage upload/download
@silvolu silvolu merged commit ce828ac into googleapis:master Dec 12, 2014
@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

Build is broken with oauthclient 1.4.3

@dhermes
Copy link
Contributor

dhermes commented Dec 13, 2014

Link to broken test?

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/43892995#L307

@dhermes
Copy link
Contributor

dhermes commented Dec 13, 2014

Lovely. We fixed broken Py3 support and I'm sure other people are even more broken by this. oauth2client really needs some TLC.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

I'll pin to 1.3 meanwhile.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

Aaaand we're back to green.

@dhermes
Copy link
Contributor

dhermes commented Dec 13, 2014

Did you file a bug with @craigcitro? I'm unclear on why / where pinning to 1.3.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

I didn't, but I'll investigate as soon as I can.

@craigcitro
Copy link
Contributor

craigcitro commented Dec 13, 2014

broken in python 3 only? (on phone)

On Fri, Dec 12, 2014, 7:01 PM Silvano Luciani [email protected]
wrote:

I didn't, but I'll investigate as soon as I can.

—
Reply to this email directly or view it on GitHub
#414 (comment)
.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

Broken on 2.7. I'm investigating now.

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

This is the change that's creating the error:
googleapis/oauth2client@3c647bd#diff-d8b1525b7f161cbce2f6438636be9c38L412

@silvolu
Copy link
Contributor Author

silvolu commented Dec 13, 2014

Ha! The AttributeError: 'int' object has no attribute 'encode' error is raised when the Content-Length header undergoes cleaning, because its value is an int. This doesn't happen in datastore because the value of the header is explicitly converted to string here, whereas in storage it's not.
I'll fix the storage connection and remove the pinning.

@dhermes
Copy link
Contributor

dhermes commented Dec 13, 2014

@craigcitro k.encode('ascii') should be changed to something closer to the behavior of str(k) in Python2. This is a bit problematic because six.binary_type(k) fails without an encoding and six.binary_type(k, 'ascii') fails in Python2 (at most one argument).

@tseaver tseaver mentioned this pull request Dec 31, 2014
Closed
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#414)
fca429c 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#414)
a3af780 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#414)
2d20c96 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#414)
7309197 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-documentai to v2.3.0 (#414)
c333ea1
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#414)
4400be7 
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@release-please
chore(main): release 2.8.0 (#414)
ac4b350 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@nicain
docs: add streaming detect intent with partial response sample (#414)
ab346d4 
* docs: add streaming detect intent with partial response sample

* linting
parthea added a commit that referenced this pull request Sep 20, 2023
@renovate-bot @parthea
chore(deps): update dependency google-cloud-bigquery to v3.11.0 (#414)
e310285 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
b5a2af0 
…v3.8.0 (#414)
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency backoff to v2.0.1 (#414)
1f233a3
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 3.8.0 (#414)
641047b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#414)
1a48b75
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#414)
8bf6920 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: store artifacts in placer [autoapprove] (#414)
e6487c1 
Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): allow client documentation to be customized in README (#…
03fad2c 
…414)

Source-Link: googleapis/synthtool@95d9289
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 3.17.1 (#414)
733e11a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#414)
c93cb7a 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* trigger CI

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Aug 21, 2025
@parthea @gcf-owl-bot @steffnay
fix: handle AttributeError in bigquery_storage writer (#414)
19a57d7 
* fix: resolve AttributeError in bigquery_storage writer

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* handle AttributeError to avoid race condition

* actually catch AttributeError

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Steffany Brown <[email protected]>
parthea added a commit that referenced this pull request Sep 16, 2025
@parthea @gcf-owl-bot @steffnay
fix: handle AttributeError in bigquery_storage writer (#414)
4379d58 
* fix: resolve AttributeError in bigquery_storage writer

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* handle AttributeError to avoid race condition

* actually catch AttributeError

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Steffany Brown <[email protected]>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: bump cryptography from 41.0.5 to 41.0.6 in /synthtool/gcp/temp…
359c2cc 
…lates/python_library/.kokoro (#414)

Source-Link: googleapis/synthtool@9367caa
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f155882785883336b4468d5218db737bb1d10c9cea7cb62219ad16fe248c03c

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tswast
deps: require google-cloud-bigquery-storage to avoid performance warn…
1cf21c7 
…ing (#414)

The wrapped DB-API uses google-cloud-bigquery-storage to download query
results by default. It raises a warning and falls back to the REST API
if google-cloud-bigquery-storage is not installed.

The google-cloud-bigquery version 3.x library is tested in #401 and it does not include any breaking changes that should affect the SQLAlchemy connector.

deps: allow google-cloud-bigquery version 3.x

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
tests: allow prerelease deps on Python 3.9 (#415)
2bfb2cf 
Closes #414.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@cguardia
build: get kokoro file generation in sync with synthtool (#418)
999ecc7 
refs #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@silvolu @coveralls @tseaver @dhermes @craigcitro