Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 29, 2017

Skips the new test unless an environment variable, GOOGLE_CLOUD_TESTS_USER_PROJECT, is set.

@lukesneeringer What project should that be set to for CI?

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing labels Sep 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Sep 29, 2017

This test, and more to be added shortly, should be in place on the storage-requester_pays-feature branch before merging #4056.

@dhermes
Copy link
Contributor

dhermes commented Sep 29, 2017

@tseaver What is RUD?

Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bucket.update()
self.assertEqual(bucket.labels, {})

@unittest.skipUnless(USER_PROJECT, 'USER_PROJECT not set in environment.')

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor Author

tseaver commented Sep 29, 2017

RUD is CRUD without the C (because we tested that already.

@tseaver tseaver merged commit f648e08 into googleapis:storage-requester_pays-feature Sep 29, 2017
@tseaver tseaver deleted the storage-requester_pays-systests branch September 29, 2017 17:17
@tseaver
Copy link
Contributor Author

tseaver commented Sep 29, 2017

@lukesneeringer Do you have a sense about the project ID we should use for the user_project system tests?

tseaver added a commit that referenced this pull request Oct 2, 2017
…t' set (#4084)

* Pass through extra posargs for system tests.

* Plumb 'user_project' arg through 'Client.bucket'.
tseaver added a commit that referenced this pull request Oct 5, 2017
…ct' set (#4084)

* Pass through extra posargs for system tests.

* Plumb 'user_project' arg through 'Client.bucket'.
tseaver added a commit that referenced this pull request Oct 10, 2017
…ct' set (#4084)

* Pass through extra posargs for system tests.

* Plumb 'user_project' arg through 'Client.bucket'.
tseaver added a commit that referenced this pull request Oct 10, 2017
…ct' set (#4084)

* Pass through extra posargs for system tests.

* Plumb 'user_project' arg through 'Client.bucket'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants