Skip to content

Just refer to operations as being like Future. #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukesneeringer merged 1 commit into from
Sep 25, 2017
Merged

Just refer to operations as being like Future. #4046

lukesneeringer merged 1 commit into from
Sep 25, 2017

Conversation

@lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Sep 23, 2017

Uses #4028 as a base.

Addresses the third of @jonparrott's individual documentation concerns.

@lukesneeringer lukesneeringer added api: spanner Issues related to the Spanner API. spanner beta labels Sep 23, 2017
@lukesneeringer lukesneeringer self-assigned this Sep 23, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2017
@theacodes theacodes mentioned this pull request Sep 23, 2017
Merged
7 tasks
@lukesneeringer lukesneeringer added this to the Spanner Beta milestone Sep 23, 2017
dhermes
dhermes approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukesneeringer lukesneeringer merged commit 03a2efe into googleapis:spanner-beta Sep 25, 2017
@lukesneeringer lukesneeringer deleted the no-fake-operation branch September 25, 2017 20:29
lukesneeringer added a commit that referenced this pull request Sep 26, 2017
@lukesneeringer
Just refer to operations as being like Future. (#4046)
c0fc70f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@tseaver tseaver tseaver approved these changes

@theacodes theacodes theacodes approved these changes

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukesneeringer @tseaver @theacodes @dhermes @googlebot