fix empty set #404

lucemia · 2014-12-03T07:58:17Z

for issue #403

for test case. I am curious about whether to create a new test case test_save_entity_w_transaction_list_value and included #399.

coveralls · 2014-12-03T08:01:02Z

Coverage decreased (-0.01%) when pulling 79ff1a3 on lucemia:property-with-empty-list into 5457564 on GoogleCloudPlatform:master.

tseaver · 2014-12-03T14:26:27Z

If we aren't going to marshall the value, then we should probably be preventing assignment of it in __setitem__() and update(). Otherwise, we might need to fabricate a custom entity_value to be used for this case.

lucemia · 2014-12-03T17:46:21Z

@tseaver
preventing assignment via __setitem__ and update() looks will fail in the following case..

entity = Entity(dataset, 'test')
entity['a'] = []
entity['a'].append(1)

tseaver · 2014-12-05T18:12:02Z

Silently dropping the attribute-with-empty-list during save() will mean that it is missing when loaded again.

dhermes · 2014-12-19T20:08:48Z

Is this PR dead? It's certainly silent.

tseaver · 2014-12-19T20:19:54Z

@dhermes how would you envision dealing with an entity where the property value (in Python) is an empty list? We can't marshall that to the protobuf "normally", becase an empty list_value field doesn't satisfy the criterion that the property have a value set.

I posted in #403 (comment) a reference to an alternate implementation, which creates an entity_value for the property with an empty list, but didn't create a PR from that branch.

dhermes · 2014-12-19T21:30:58Z

@tseaver Sorry I wasn't trying to claim #403 is dead / fixed, just this PR. I looked at the alternate implementation, but am not a big fan of things like '_gcloud:empty_list'.

Has anyone been able to send an empty list using just proto objects?

dhermes · 2014-12-21T07:20:21Z

@tseaver I commented on the original issue as well, but I think the "correct" / simplest fix would be to change the code you focus on in your solution:

    elif attr == 'list_value':
        if len(val) == 0:
            continue
        l_pb = value_pb.list_value
        for item in val:

tseaver · 2014-12-21T15:36:25Z

We would need to document that some values (empty lists, None, etc.) cannot be saved to the back-end.

dhermes · 2014-12-21T18:20:08Z

I agree. I wonder if the datastore folks also document that it's not possible to do?

lucemia · 2014-12-22T03:50:04Z

If we document this behavior,

We would need to document that some values (empty lists, None, etc.) cannot be saved to the back-end.

I guess we don't need to have '_gcloud:empty_list' ?

dhermes · 2014-12-22T07:14:52Z

Just a tiny code change which never adds the property and documents that empty lists aren't stored.

lucemia · 2014-12-22T09:44:36Z

@dhermes
if I fixed the helpers.py to

elif attr == 'list_value':
        if len(val) == 0:
            return
        l_pb = value_pb.list_value
        for item in val:
            i_pb = l_pb.add()
            _set_protobuf_value(i_pb, item)
    else:  # scalar, just assign
        setattr(value_pb, attr, val)

it will still raise the following exception

Traceback (most recent call last):
  File "test.py", line 26, in <module>
    entity.save()
  File "/Users/david/repos/gcloud-python/gcloud/datastore/entity.py", line 245, in save
    exclude_from_indexes=self.exclude_from_indexes())
  File "/Users/david/repos/gcloud-python/gcloud/datastore/connection.py", line 482, in save_entity
    result = self.commit(dataset_id, mutation)
  File "/Users/david/repos/gcloud-python/gcloud/datastore/connection.py", line 382, in commit
    datastore_pb.CommitResponse)
  File "/Users/david/repos/gcloud-python/gcloud/datastore/connection.py", line 95, in _rpc
    data=request_pb.SerializeToString())
  File "/Users/david/anaconda/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 813, in SerializeToString
    self.DESCRIPTOR.full_name, ','.join(self.FindInitializationErrors())))
google.protobuf.message.EncodeError: Message api.services.datastore.CommitRequest is missing required fields: mutation.insert_auto_id[0].property[0].value

so I check the list value in connection.py https://github.com/GoogleCloudPlatform/gcloud-python/pull/404/files

dhermes · 2014-12-22T17:06:32Z

Right, adding the property should never happen. My bad for indicating otherwise.

coveralls · 2014-12-28T05:20:08Z

Coverage remained the same when pulling 9e2d1f0 on lucemia:property-with-empty-list into 5457564 on GoogleCloudPlatform:master.

lucemia · 2014-12-28T14:53:42Z

The test case is added :)

…list or none value

coveralls · 2014-12-29T04:05:50Z

Coverage remained the same when pulling 15a507e on lucemia:property-with-empty-list into 5457564 on GoogleCloudPlatform:master.

gcloud/datastore/test_connection.py

dhermes · 2014-12-30T23:23:19Z

You should also add a test for save_entities. This makes me think the change should happen in the to_protobuf method.

Also, for such a small change, we have quite a few do-nothing commits in this PR. Do you mind squashing into a single commit and re-writing your history? I'm happy to help if you like.

lucemia · 2014-12-31T01:57:41Z

@dhermes
I find a workaround today only need to modify the _set_protobuf_value in helpers.py.

elif attr == 'list_value':
        l_pb = value_pb.list_value
        if len(val) == 0:
            x = l_pb.add()
            l_pb.remove(x)

or

if len(val) == 0:
    l_pb.extend([])

dhermes · 2014-12-31T02:00:42Z

@lucemia That's great! I'm a little confused as to why it works. Wouldn't we be better clearing value_pb from its parent?

Also, provided we can agree on this proposed workaround, want to just close this PR and open a new one (so as not to have to worry about re-writing history)?

Make sure to polish up and run tox locally before committing / submitting the PR.

lucemia · 2014-12-31T02:49:07Z

Wouldn't we be better clearing value_pb from its parent?

Thx @dhermes

I am now very sure which parent you mention, would you mind to provide more detail therefore I can add it to my new PR?

I will open a new PR with new workaround and close current one.

dhermes · 2014-12-31T02:59:43Z

Well the issue is that the only thing _set_protobuf_value receives is an instance of datastore_v1_pb2.Value (via value_pb).

However, we actually want to remove a datastore_v1_pb2.Property (which owns value_pb) from a datastore_v1_pb2.Entity object such as an auto insert in a mutation:

>>> insert_auto = mutation.insert_auto_id.add()
>>> prop = insert_auto.property.add()
>>> # Do some stuff
>>> # Oops didn't mean to add the property
>>>  insert_auto.property.remove(prop)

Unfortunately, it appears that there is no public API for retrieving a parent, so our best way forward may be a re-thinking of which data gets passed to _set_protobuf_value.

I took a stab with the non-public API provided by protobuf and it is not very pleasant. (Though it's also irrelevant since we can't rely on unsupported behavior.)

No need to close this one until we get the right solution actually sorted out.

lucemia · 2014-12-31T04:31:15Z

@dhermes

I created two branch and did some test with the following code.

conn = datastore.connection.Connection(credentials)
result = conn.save_entity(DATASET_ID, key_pb, {
    'foo': u'Foo',
    'bar': None,
    'bar1': []
})

While saving a empty list to cloud datastore:

method1 fix the `_set_protobuf_value`

lucemia@5e4d5b9
this method will save the property with null value.

method2 fix the `save_entity`

lucemia@2c3defa
this method will drop the property.

I also test the same condition on ndb (with remote_api_shell), the ndb will drop repeated property with empty list (like method2). So I think the original approach (fix the save_entity) works better. If it sounds make sense, I will rebase the branch property-with-empty-list.

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* feat: added font_family to document.proto feat: added ImageQualityScores message to document.proto feat: added PropertyMetadata and EntityTypeMetadata to document_schema.proto PiperOrigin-RevId: 486975621 Source-Link: googleapis/googleapis@398c9f9 Source-Link: googleapis/googleapis-gen@7cd1f5f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2NkMWY1ZjRlNDM1Nzc3Y2I4MjRhZjI2OGRjOGQzNzEzNDYxM2U2YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update constraints-3.7.txt Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Holt Skinner <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…#404)

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Source-Link: googleapis/synthtool@d2871d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: support per-entity search and autocomplete feat: add model get API feat: support new filter syntax for recommendation feat: expose A/B experiment info in search response docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 522675546 Source-Link: googleapis/googleapis@81b0808 Source-Link: googleapis/googleapis-gen@e950439 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk1MDQzOWNkMGQ0ODZhYjhkMmIzMjY3MmI1NGMwYTZiNjQ1MTQyMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add model service feat: support per-entity search and autocomplete feat: support new filter syntax for recommendation feat: expose A/B experiment info in search response docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 522675951 Source-Link: googleapis/googleapis@f149e91 Source-Link: googleapis/googleapis-gen@c4538a8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ1MzhhODg4ZDJlYzEzY2U3MTljMWExYWE5ZGM3ZGU1YjE3Mzc1YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add merchant center link service feat: support per-entity search and autocomplete feat: expose facets and product counts in autocomplete feat: add model get API feat: allow cascaded deletion on primary product feat: support new filter syntax for recommendation feat: expose A/B experiment info in search response docs: keep the API doc up-to-date with recent changes PiperOrigin-RevId: 523140513 Source-Link: googleapis/googleapis@4a9f933 Source-Link: googleapis/googleapis-gen@ffb754a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmZiNzU0YTdkMmNkNzkzODBmYjVjY2ZkMzNhMWMwOTA4ZGJiNjJhNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs(samples): adds training phrases sample * docs(samples): fixed lint * docs(samples): ignored auto-foratting Co-authored-by: Anthonios Partheniou <[email protected]>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.9.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.9.0...v2.9.1) (2021-10-04) ### Documentation * **samples:** adds training phrases sample ([#404](https://www.github.com/googleapis/python-dialogflow/issues/404)) ([9d98f9b](https://www.github.com/googleapis/python-dialogflow/commit/9d98f9b47208cbbdee13f678000c2970387c716e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * add owlbot.py to exclude generated gapic_version.py * set manifest to true in .github/release-please.yml * add release-please-config.json * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: added Location API methods docs: updated comments PiperOrigin-RevId: 489094434 Source-Link: googleapis/googleapis@71673d8 Source-Link: googleapis/googleapis-gen@1017723 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTAxNzcyMzJkNDIwMDA2NjEwYWU5ZmI3NDBkOWYxM2VmZTk3NWNiOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…le (#404) Source-Link: googleapis/synthtool@a7ed11e Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:effb79ef0525b02611cada94df8d7a248758928579c03d522f26ed37f9867668 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7e1f6da Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:a1a891041baa4ffbe1a809ac1b8b9b4a71887293c9101c88e8e255943c5aec2d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: omair <[email protected]>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@dd05f9d Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:aea14a583128771ae8aefa364e1652f3c56070168ef31beb203534222d842b8b

@busunkim96

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

@gaborfeher

@gaborfeher pointed at that while we were trying to use a `keys_only` query for `Query.count()` we were failing to actually do so. This is @gaborfeher's proposed fix from PR #400, fleshed out with unit tests. Fixes #404.

@busunkim96

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

fix empty set

79ff1a3

lucemia added 2 commits December 28, 2014 13:10

add test case

0d86944

fix pep8

9e2d1f0

document the save_entity will ignore properties whose value is empty …

15a507e

…list or none value

dhermes reviewed Dec 30, 2014
View reviewed changes

gcloud/datastore/test_connection.py

This comment was marked as spam.

Sign in to view

This was referenced Jan 9, 2015

Storing an Entity as an indexed property value always fails #529

Closed

#514: rip out Connection cruft #550

Merged

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 3.9.0 (#404)

2567f82

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.17.0 (#404)

6f5ca66

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-secret-manager to v2.16.0 (…

898534f

…#404)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.29.0 (#404)

f102e66

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Aug 21, 2025

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#404)

d9679d5

parthea added a commit that referenced this pull request Sep 16, 2025

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#404)

b3fa3da

parthea pushed a commit that referenced this pull request Nov 24, 2025

build: update the list of required status check contexts (#404)

b847605

Co-authored-by: omair <[email protected]>

fix empty set #404

fix empty set #404

Uh oh!

Conversation

lucemia commented Dec 3, 2014

Uh oh!

coveralls commented Dec 3, 2014

Uh oh!

tseaver commented Dec 3, 2014

Uh oh!

lucemia commented Dec 3, 2014

Uh oh!

tseaver commented Dec 5, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

tseaver commented Dec 19, 2014

Uh oh!

dhermes commented Dec 19, 2014

Uh oh!

dhermes commented Dec 21, 2014

Uh oh!

tseaver commented Dec 21, 2014

Uh oh!

dhermes commented Dec 21, 2014

Uh oh!

lucemia commented Dec 22, 2014

Uh oh!

dhermes commented Dec 22, 2014

Uh oh!

lucemia commented Dec 22, 2014

Uh oh!

dhermes commented Dec 22, 2014

Uh oh!

coveralls commented Dec 28, 2014

Uh oh!

lucemia commented Dec 28, 2014

Uh oh!

coveralls commented Dec 29, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

lucemia commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

lucemia commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

lucemia commented Dec 31, 2014

method1 fix the _set_protobuf_value

method2 fix the save_entity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

method1 fix the `_set_protobuf_value`

method2 fix the `save_entity`