Fix doc build by swapping install order #3828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Aug 16, 2017
Contributor
|
This is a lose-lose, sadly. @lukesneeringer fixed this previously, but I undid it in #3730. The reason: if our source tree depends on packages that are not yet on PyPI, the build won't work. |
Contributor
Author
|
I see - ideally we should just stop installing the umbrella package for docs. |
Contributor
|
Yeah great point. It's not necessary? Or maybe |
Contributor
Author
|
|
Contributor
|
That seems like the "least worst" strategy. The version used in the user agent comes from |
Contributor
Author
|
I have a day of meetings - if you're willing (and able) to do that today I'll review. |
Contributor
|
On it |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Aug 16, 2017
dhermes
added a commit
that referenced
this pull request
Aug 16, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.