Fix #83: Add 'exclude_from_indexes' method to Entity. #330

tseaver · 2014-11-03T21:00:56Z

Set it via ctor argument.

Pass it to Connection.save_entity.

Fields in the sequence will have the indexed field set False in the
corrsponding protobuf.

Fixes #83.

coveralls · 2014-11-03T21:10:11Z

Coverage remained the same when pulling 79b4d5a on tseaver:83-expose_entity_indexed into f33e557 on GoogleCloudPlatform:master.

gcloud/datastore/connection.py

dhermes · 2014-11-03T21:53:44Z

@silvolu Do you guys support this in gcloud-node? If yes, is there a reason there aren't regression tests for it?

For example, a simple test like:

e1 = dataset.entity(kind='Test')
e1['name'] = 'val'
e1.save()

e2 = dataset.entity(kind='Test')
e2['name'] = 'val'
e2._exclude_from_indexes = set(['name'])
e2.save()

query = dataset.query('Test').filter('name =', 'val').limit(2)
results = query.fetch()

# Make sure len(results) == 1

@tseaver Shouldn't we have support for this in the Dataset convenience method for creating an Entity?

tseaver · 2014-11-03T22:03:29Z

Ugh, yet more reasons to detest those "convenience" APIs. ;)

coveralls · 2014-11-03T22:18:55Z

Coverage remained the same when pulling 6b8f52a on tseaver:83-expose_entity_indexed into f33e557 on GoogleCloudPlatform:master.

dhermes · 2014-11-03T22:26:49Z

Indeed. We should work hard to have a single entry point, but one that is very nice.

The "old way", i.e. within the App Engine environment, the dataset ID is always known, so users can just skip right to creating entities. Maybe we could do similar here by reading an env var or modifying a constant on a module or something else.

silvolu · 2014-11-04T00:10:20Z

@dhermes we support it in a different way (you set it on the attribute), and we have unit tests only for it, given that the essence of it is setting the correct value on the pb sent over.
Also, I guess a regression test would have to test that the query is failing because the index doesn't exist?

dhermes · 2014-11-04T00:20:35Z

@silvolu An equality query on a single property does not require an index.

My test code above should return a single entry (# Make sure len(results) == 1) even though two entries match the query; this is because one of those two has the field unindexed. This is makes sure that the way we set the pb's is the correct one.

FWIW I'm a bit worried about more regression tests as they already take a fair bit of time to run. Maybe we could have a simple suite and an expanded suite that runs only when releases are cut.

silvolu · 2014-11-04T00:43:53Z

@dhermes I seem to constantly forget how indexes work :)
I think it's fine if we don't test this against the prod api.
In general though I'd be more inclined to run a more complete suite of functional tests upon merges, so that we can catch potential breaks in a timely fashion and fix the cause.

dhermes · 2014-11-04T16:39:14Z

Everything looks good except for str vs. unicode question

tseaver · 2014-11-04T17:38:24Z

@dhermes 4c4f891 updates the docstring entries for exclude_from_indexes to avoid mandating the type of the field names.

dhermes · 2014-11-04T17:39:45Z

@tseaver Thanks for making the change. LGTM.

I'm still unclear if using unicode for kind names will cause something to break either in our library or on the GCD server.

coveralls · 2014-11-04T17:45:44Z

Coverage remained the same when pulling 4c4f891 on tseaver:83-expose_entity_indexed into f33e557 on GoogleCloudPlatform:master.

Set it via ctor argument. Pass it to 'Connection.save_entity'. Fields in the sequence will have the 'indexed' field set False in the corrsponding protobuf. Fixes #83.

@dhermes

Incorporates feedback from @dhermes.

@dhermes

Incorporates feedback from @dhermes.

tseaver · 2014-11-04T17:58:45Z

Rebased to resolve conflict from #331.

coveralls · 2014-11-04T18:07:08Z

Coverage remained the same when pulling 5762cbf on tseaver:83-expose_entity_indexed into abe3d7c on GoogleCloudPlatform:master.

dhermes · 2014-11-04T18:17:47Z

Still LGTM. Still unclear about using unicode kinds.

Fix #83: Add 'exclude_from_indexes' method to Entity.

…ed (googleapis#330 and googleapis#294) Updated Readme to reflect this change

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

…#330) Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: use gapic-generator-python 0.65.2 PiperOrigin-RevId: 444333013 Source-Link: googleapis/googleapis@f91b6cf Source-Link: googleapis/googleapis-gen@16eb360 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs(dlp-samples): modified region tags and fixed comment * lint fix

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

- [x] Regenerate this pull request now. fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

This way necessary version ranges for transitive dependencies such as google-cloud-bigquery-storage and pyarrow are included in the installation.

Create wrapped Protos in two stages: 1) Load messages and enums 2) Load services and methods This allows methods to reference _all_ messages in the entire API surface without having to rely on explicit imports. This is a workaround for a common case of #318 where an LRO response or metadata type is referenced as a string in the method annotation but is not a visible, imported type.

Source-Link: googleapis/synthtool@fac8444 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 1.22.0 * add changelog for PR #327 * ci: fix docs build Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@9ae0785 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore: add pre-commit-config to renovate ignore paths Disable renovate PRs on the .pre-commit-config.yaml which is templated from synthtool. https://docs.renovatebot.com/configuration-options/#ignorepaths Source-Author: Bu Sun Kim <[email protected]> Source-Date: Mon Mar 15 09:05:39 2021 -0600 Source-Repo: googleapis/synthtool Source-Sha: 2c54c473779ea731128cea61a3a6c975a08a5378 Source-Link: googleapis/synthtool@2c54c47 Co-authored-by: Christopher Wilcox <[email protected]>

In Python 2.7, classes which use `__slots__` can't be pickled. Users have reported problems trying to pickle NDB entities, indicating there is some perceived use case for pickling entities. Fixes #311

dhermes reviewed Nov 3, 2014
View reviewed changes

gcloud/datastore/connection.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits November 4, 2014 12:56

Add 'exclude_from_indexes' method to Entity.

72d85f2

Set it via ctor argument. Pass it to 'Connection.save_entity'. Fields in the sequence will have the 'indexed' field set False in the corrsponding protobuf. Fixes #83.

Expose 'exclude_from_indexes' via 'Dataset.entity()'.

41a0412

Incorporates feedback from @dhermes.

Avoid mandating type of field names passed to 'exclude_from_indexes'.

5762cbf

Incorporates feedback from @dhermes.

tseaver added a commit that referenced this pull request Nov 4, 2014

Merge pull request #330 from tseaver/83-expose_entity_indexed

df05a0e

Fix #83: Add 'exclude_from_indexes' method to Entity.

tseaver merged commit df05a0e into googleapis:master Nov 4, 2014

tseaver deleted the 83-expose_entity_indexed branch November 4, 2014 18:33

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

When using the credentials auth_flow_type the tenant_id is now requir…

b262579

…ed (googleapis#330 and googleapis#294) Updated Readme to reflect this change

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.2.1 (#330)

066f977

parthea added a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-securitycenter to v1.11.0 (…

ab1428b

…#330) Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency grpcio to v1.57.0 (#330)

3fd1fe9

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.2.1 (#330)

affa7d7

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.16.0 (#330)

e0c7080

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-dataproc to v3.2.0 (#330)

0a266df

parthea pushed a commit that referenced this pull request Sep 22, 2023

docs(dlp-samples): modified region tags and fixed comment (#330)

09707f5

* docs(dlp-samples): modified region tags and fixed comment * lint fix

parthea added a commit that referenced this pull request Sep 22, 2023

chore: test minimum dependencies in python 3.7 (#330)

be93d2e

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-bigquery to v2.30.0 (#330)

4d4074a

parthea pushed a commit that referenced this pull request Oct 21, 2023

docs: fixed 'annotate an image' (#330)

1aa18d7

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-admin to v0.15.0 (#330)

157a9b6

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.2.1 (#330)

f0e35e0

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 2.5.0 (#330)

2870aed

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 26, 2025

doc: clarify which SA has Token Creator role (#330)

fdc2680

Fix #83: Add 'exclude_from_indexes' method to Entity. #330

Fix #83: Add 'exclude_from_indexes' method to Entity. #330

Uh oh!

Conversation

tseaver commented Nov 3, 2014

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

tseaver commented Nov 3, 2014

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

silvolu commented Nov 4, 2014

Uh oh!

dhermes commented Nov 4, 2014

Uh oh!

silvolu commented Nov 4, 2014

Uh oh!

dhermes commented Nov 4, 2014

Uh oh!

tseaver commented Nov 4, 2014

Uh oh!

dhermes commented Nov 4, 2014

Uh oh!

coveralls commented Nov 4, 2014

Uh oh!

tseaver commented Nov 4, 2014

Uh oh!

coveralls commented Nov 4, 2014

Uh oh!

dhermes commented Nov 4, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants