Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

tseaver · 2014-10-31T23:10:50Z

tseaver · 2014-10-31T23:12:02Z

Presumes #318 is landed first.

coveralls · 2014-10-31T23:14:52Z

Coverage remained the same when pulling 99b78b2 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 8e12e10 on GoogleCloudPlatform:master.

dhermes · 2014-10-31T23:18:55Z

I'll hold off review until #318 lands. Please remind me if I forget.

- Refactor lazy-handling of 'acl' and 'default_object_acl' using properties. - Fetch 'ac' and 'defaultObjectAcl' via GET to specific endpoints. - Continue to update 'acl' and 'defaultObjectAcl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #163.

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

Fixes #324.

tseaver · 2014-11-01T02:03:34Z

@dhermes Rebased after landing #318.

coveralls · 2014-11-01T02:05:41Z

Coverage remained the same when pulling 9cfe627 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

gcloud/storage/acl.py

@dhermes

Drop unneeded comment. Feedback from @dhermes.

coveralls · 2014-11-03T18:37:09Z

Coverage remained the same when pulling bb9a3a8 on tseaver:324-move_acl_manip_from_bucket_key_to_acl into 632e126 on GoogleCloudPlatform:master.

tseaver · 2014-11-03T19:41:05Z

@dhermes PTAL.

dhermes · 2014-11-03T21:48:13Z

LGTM

I really wish GitHub would let us keep track of what we had already reviewed and then pick and choose which commits the left-hand and right-hand diffs are in the side-by-side view.

…ey_to_acl Fix #324: Move ACL back-end manipulations from bucket / key to acl objects

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…326) Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

….13.0 (#326)

Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

* ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add a commit to activate gh actions * workaround bug in templates Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…p/templates/python_library/.kokoro (#326) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

Co-authored-by: Anthonios Partheniou <[email protected]>

…[autoapprove] (#326) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

E.g. import.proto turns into import_.py, not import.py This allows the module to be imported via the normal import mechanisms.

Source-Link: googleapis/synthtool@3551acd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:230f7fe8a0d2ed81a519cfc15c6bb11c5b46b9fb449b8b1219b3771bcb520ad2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: update .repo-metadata.json * revert * remove api_shortname

Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. Co-authored-by: Christopher Wilcox <[email protected]>

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. labels Oct 31, 2014

tseaver added 4 commits October 31, 2014 21:58

Use ACL-specific endpoints where feasible for keys.

65d9962

- Refactor lazy-handling of 'acl' using a property. - Fetch 'acl' via GET to a specific endpoint. - Continue to update 'acl' via PATCH to the object's resource (we can't do incremental updates to ACEs). Fixes #151.

Fix save/clear ACL operations.

417333c

Borked by dropping the 'projection' qs param to PATCH. Docs spell a default, but then note that overriding it w/ 'full' is required (and we need 'full' anyway, because we expect to read the resulting ACL back).

Move APIs for reload/save/clear ACLs onto ACL objects themselves.

9cfe627

Fixes #324.

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 1, 2014

dhermes reviewed Nov 1, 2014
View reviewed changes

gcloud/storage/acl.py Outdated

This comment was marked as spam.

Sign in to view

tseaver added 3 commits November 3, 2014 13:23

Rename 'dirty'->'save_to_backend'.

d7a1beb

Drop unneeded comment. Feedback from @dhermes.

Use 'add_entity' directly when populating from scratch.

5689c02

Improve class attr name: '_SUBKEY'->'_URL_PATH_ELEM'.

bb9a3a8

tseaver added a commit that referenced this pull request Nov 3, 2014

Merge pull request #326 from tseaver/324-move_acl_manip_from_bucket_k…

963d0dd

…ey_to_acl Fix #324: Move ACL back-end manipulations from bucket / key to acl objects

tseaver merged commit 963d0dd into googleapis:master Nov 3, 2014

tseaver deleted the 324-move_acl_manip_from_bucket_key_to_acl branch November 6, 2014 22:43

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

logging resumable upload expiration datetime for debug googleapis#326

38700f6

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-auth to v2.16.0 (#326)

3d74264

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-bigquery-connection to v1…

b364876

….13.0 (#326)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.15.0 (#326)

2fe876f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-storage to v2 (#326)

48aaf55

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea added a commit that referenced this pull request Sep 22, 2023

chore(main): release 3.6.1 (#326)

0f8ef07

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.2.2 (#326)

f2b1d95

parthea added a commit that referenced this pull request Sep 22, 2023

fix(deps): require protobuf <4.0.0dev (#326)

a7dce25

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-kms to v2.12.1 (#326)

219332f

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-storage to v2.2.0 (#326)

cc732af

parthea added a commit that referenced this pull request Oct 21, 2023

chore: make samples 3.6 check optional (#326)

fc95b37

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea added a commit that referenced this pull request Jan 10, 2025

chore: remove pb2 file generation during post processing step (#326)

729f598

parthea added a commit that referenced this pull request Nov 22, 2025

fix(deps): add packaging requirement (#326)

835ec33

parthea pushed a commit that referenced this pull request Nov 24, 2025

Disambiguate Python-keyword-named modules (#326)

6eb7e15

E.g. import.proto turns into import_.py, not import.py This allows the module to be imported via the normal import mechanisms.

parthea added a commit that referenced this pull request Nov 24, 2025

chore: update release_level in repo-metadata.json (#326)

948d129

* chore: update .repo-metadata.json * revert * remove api_shortname

parthea added a commit that referenced this pull request Nov 24, 2025

fix: Declare support for Python 3.13 (#326)

68db541

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 2.7.0 (#326)

fb00386

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Nov 1, 2014

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

tseaver commented Nov 3, 2014

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Fix #324: Move ACL back-end manipulations from bucket / key to acl objects #326

Uh oh!

Conversation

tseaver commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Nov 1, 2014

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 3, 2014

Uh oh!

tseaver commented Nov 3, 2014

Uh oh!

dhermes commented Nov 3, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants