Fixing corner case where lint doesn't run outside of a PR. #325

dhermes · 2014-10-31T20:49:52Z

No description provided.

coveralls · 2014-10-31T20:56:28Z

Coverage remained the same when pulling 691b9f4 on dhermes:make-lint-run-always into 8e12e10 on GoogleCloudPlatform:master.

dhermes · 2014-10-31T21:02:24Z

@silvolu @tseaver This should be a quick review.

I realized that git diff origin/master is pretty useless when we're on origin/master so the speedup is only applied during a PR.

To get a sense for what Travis clones / checks out in a PR build, check out the output from a dummy build I made:

$ echo ${TRAVIS_PULL_REQUEST}
2
$
$ git branch -vv
* (detached from FETCH_HEAD) 6c26349 Merge a70ea6b3c3c7df4661436b0dea9b31d651cb9dba into d4c46af11107089cfd8ee8cde1077243ddd3ed7e
  master                     d4c46af [origin/master] Moar spurious blank lines.

tseaver · 2014-10-31T23:13:47Z

LGTM.

Fixing corner case where lint doesn't run outside of a PR.

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py * add gapic_version.py * feat: add account_verification field to Assessment for MFA PiperOrigin-RevId: 493691493 Source-Link: googleapis/googleapis@c9560d8 Source-Link: googleapis/googleapis-gen@ec825c8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWM4MjVjOGVmOTk4N2I2N2Q0M2RmZmZhYjUwOTE0ZTAzMjI3NWQ2MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Add service_yaml_parameters to py_gapic_library BUILD.bazel targets PiperOrigin-RevId: 510187992 Source-Link: googleapis/googleapis@5edc235 Source-Link: googleapis/googleapis-gen@b0bedb7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBiZWRiNzJlNDc2NWEzZTBiNjc0YTI4YzUwZWEwZjlhOWIyNmE4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

* wrong package name in pip install (#323) * fix package name in get_distribution (#324) Co-authored-by: Monty Montemayor <[email protected]>

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

)

* chore: Update gapic-generator-python to v1.11.2 PiperOrigin-RevId: 546510849 Source-Link: googleapis/googleapis@736073a Source-Link: googleapis/googleapis-gen@deb64e8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: use gapic-generator-python 0.65.1 PiperOrigin-RevId: 441524537 Source-Link: googleapis/googleapis@2a27391 Source-Link: googleapis/googleapis-gen@ab6756a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…1.8.0 (#325)

* feat: Add support for specifying stack type for clusters. This will allow clusters to be created as dual stack or toggled between IPV4 and dual stack Clients can now configure dual stack clusters by specifying a stack type of IPV4_IPV6 during cluster creation, or with an update command. When used with a cluster creation command that creates a new subnet, the ipv6_access_type field can be used to specify whether the subnet has internal or external IPv6 access. When used with a cluster update command, the subnet must already be dual stack. PiperOrigin-RevId: 495981345 Source-Link: googleapis/googleapis@9d1290e Source-Link: googleapis/googleapis-gen@31ed74b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzFlZDc0YmJkMTk5MDM1MWE4N2JkYTFhNDU3MGJhMDgzNzQyODFiNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add WindowsNodeConfig field to v1alpha1, v1beta1, v1 --- feat: add EphemeralStorageLocalSsdConfig and LocalNvmeSsdBlockConfig APIs to v1alpha1, v1beta1, v1 PiperOrigin-RevId: 497251971 Source-Link: googleapis/googleapis@32fa620 Source-Link: googleapis/googleapis-gen@487ef77 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDg3ZWY3NzQ0NWIyNGYwYzAwOTUyY2EzMDIxNDliZjRkMjQxYjkwOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Release GKE CloudDNS Cluster Scope `CLUSTER_SCOPE` option now available in DNSScope --- feat: add WindowsNodeConfig field to v1alpha1, v1beta1, v1 --- feat: add EphemeralStorageLocalSsdConfig and LocalNvmeSsdBlockConfig APIs to v1alpha1, v1beta1, v1 PiperOrigin-RevId: 497252854 Source-Link: googleapis/googleapis@3b5011d Source-Link: googleapis/googleapis-gen@289376a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjg5Mzc2YTkwMmM5NDk2ZjRmM2NkNzlmMzMwNWNhMzJhMDZjOGY1MCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add etags for cluster and node pool update operations Clients may now optionally specify the previously read etag for a cluster or node pool during update requests. The etag is regenerated every time the object is updated. If an etag is provided, it will be checked against the current etag, and the request will be rejected on mismatch. This is particularly useful for allowing two clients to concurrently update a repeated field without overwriting each other. PiperOrigin-RevId: 498249600 Source-Link: googleapis/googleapis@9a294bf Source-Link: googleapis/googleapis-gen@f0f0e1f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjBmMGUxZmZjM2UyOGUyMDNlN2MyMzNhZjQ5MzY2ODhjOWIyYjA3ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

#325) committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

- [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency fix: fix extras_require typo in setup.py committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: googleapis/googleapis@83d81b0 Source-Link: googleapis/googleapis-gen@2ff001f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9

…[autoapprove] (#325) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

#325)

Extracted from PR #325. Closes #324.

Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Mariatta Wijaya <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]>

* fix: remove unbox json functionality from JSONArrowType * lint

Co-authored-by: Craig Labenz <[email protected]>

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

* fix: make query options convert projection properties to strings.

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

Fixing corner case where lint doesn't run outside of a PR.

691b9f4

dhermes force-pushed the make-lint-run-always branch from 92b65ef to 691b9f4 Compare October 31, 2014 20:53

dhermes added the build label Oct 31, 2014

dhermes added a commit that referenced this pull request Oct 31, 2014

Merge pull request #325 from dhermes/make-lint-run-always

26d7eef

Fixing corner case where lint doesn't run outside of a PR.

dhermes merged commit 26d7eef into googleapis:master Oct 31, 2014

dhermes deleted the make-lint-run-always branch October 31, 2014 23:16

jgeewax added the api: core label Jan 30, 2015

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Feature Request UniqueBody googleapis#325

f52dd28

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-monitoring to v2.13.0 (#325)

f6b9901

parthea pushed a commit that referenced this pull request Jun 4, 2023

fix: wrong package name google-cloud-secretmanager (#325)

42d1b0c

* wrong package name in pip install (#323) * fix package name in get_distribution (#324) Co-authored-by: Monty Montemayor <[email protected]>

parthea added a commit that referenced this pull request Jul 6, 2023

fix(deps): require protobuf <4.0.0dev (#325)

64dca2f

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-api-python-client to v2.95.0 (#325

f599a88

)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-bigquery-reservation to v…

a1b78c5

…1.8.0 (#325)

parthea pushed a commit that referenced this pull request Sep 22, 2023

build: switch to release-please for tagging (#325)

1badaa5

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.11.0 (#325)

3a4a8f0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.0 (#325)

03d7a25

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.15.0 (#325)

49ec6e3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-auth to v2.11.0 (#325)

67e505b

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update dependency google-cloud-bigquery-storage to v2.9.1 (

db08889

#325)

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update dependency google-cloud-bigquery-storage to v2.9.1 (

988b71b

#325)

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore: use templated 'noxfile.py' (#355)

fa9a4dc

Extracted from PR #325. Closes #324.

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: remove unbox json functionality from JSONArrowType (#325)

fd03bad

* fix: remove unbox json functionality from JSONArrowType * lint

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: adds synthed bundle protos (#325)

0e4c6f0

Co-authored-by: Craig Labenz <[email protected]>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: new owl bot post processor docker image (#325)

8df739e

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: make query options convert projection properties to strings (#325)

18d124c

* fix: make query options convert projection properties to strings.

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore: new owl bot post processor docker image (#325)

a74d8eb

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

parthea pushed a commit that referenced this pull request Nov 26, 2025

Release 1.6.3 (#325)

1ace9a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixing corner case where lint doesn't run outside of a PR. #325

Fixing corner case where lint doesn't run outside of a PR. #325

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fixing corner case where lint doesn't run outside of a PR. #325

Fixing corner case where lint doesn't run outside of a PR. #325

Uh oh!

Conversation

dhermes commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

dhermes commented Oct 31, 2014

Uh oh!

tseaver commented Oct 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants