Skip to content

#295 let entity save accept null value for attribute #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 3 commits into from
Oct 28, 2014
Merged

#295 let entity save accept null value for attribute #296

tseaver merged 3 commits into from
Oct 28, 2014

Conversation

@lucemia
Copy link
Contributor

@lucemia lucemia commented Oct 27, 2014

#295

Has unit test

@lucemia
Copy link
Contributor Author

lucemia commented Oct 27, 2014

will still raise

/protobuf/internal/python_message.py in SerializeToString  `api.services.datastore.CommitRequest is missing required fields: mutation.upsert[0].property[2].value` exception in protobuf

@coveralls
Copy link

coveralls commented Oct 27, 2014

Coverage Status

Coverage remained the same when pulling 3753821 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

@coveralls
Copy link

coveralls commented Oct 27, 2014

Coverage Status

Coverage remained the same when pulling 014b658 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Oct 27, 2014
View reviewed changes
gcloud/datastore/helpers.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Oct 27, 2014
Merged
tseaver
tseaver reviewed Oct 27, 2014
View reviewed changes
gcloud/datastore/test_helpers.py Outdated

This comment was marked as spam.

Sign in to view

@silvolu silvolu added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2014
@lucemia
Copy link
Contributor Author

lucemia commented Oct 28, 2014

@dhermes I didn't add NULL_PROPERTY = object() in current pull request yet because I think there are pros and cons to add sentinel value.

@coveralls
Copy link

coveralls commented Oct 28, 2014

Coverage Status

Coverage remained the same when pulling a208132 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Oct 28, 2014

LGTM.

-1 on a sentinel: _set_protobuf_value() is not an API, it only gets values from those stored in Entities, and from the filter(expr, value) method of a Query: in both cases, None is the more Pythonic way to express what the user expects, and there is no notion of a "default".

@tseaver
Copy link
Contributor

tseaver commented Oct 28, 2014

Note that we already return None from _get_value_from_value_pb() in the case that none of the fields has been set.

tseaver added a commit that referenced this pull request Oct 28, 2014
@tseaver
Merge pull request #296 from lucemia/support-null-value
7d9bfb1 
#295 let entity save accept null value for attribute
@tseaver tseaver merged commit 7d9bfb1 into googleapis:master Oct 28, 2014
@tseaver tseaver mentioned this pull request Oct 28, 2014
Closed
@lucemia lucemia deleted the support-null-value branch November 28, 2014 03:37
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Merge pull request googleapis#296 from cg6/master
5280685 
Add Drive.get_item_by_path(item_path)
atulep pushed a commit that referenced this pull request Apr 3, 2023
@parthea
chore: update .repo-metadata.json (#296)
f3cea7f
atulep pushed a commit that referenced this pull request Apr 6, 2023
@parthea
chore: update .repo-metadata.json (#296)
d579156
atulep pushed a commit that referenced this pull request Apr 6, 2023
@parthea
chore: update .repo-metadata.json (#296)
0497c40
atulep pushed a commit that referenced this pull request Apr 18, 2023
@parthea
chore: update .repo-metadata.json (#296)
f2e0eb8
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
feat: add a way to specify the conversation automatic analysis percen…
25eb6db 
…tage for the UploadConversation API when creating Analyses in Insights (#296)

* feat: add a way to specify the conversation automatic analysis percentage for the UploadConversation API when creating Analyses in Insights

PiperOrigin-RevId: 513416013

Source-Link: googleapis/googleapis@dacdbc8

Source-Link: googleapis/googleapis-gen@7e3cf93
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2UzY2Y5MzMwMDA0NWU5YTVjYmZiMTkwMDJkMWNkNGNiOTNiMDZkMCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.1 (#296)
3ad7023
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): exclude setup.py in renovate config (#296)
5c8d53f 
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @parthea
chore(deps): update dependency pytest to v7 (#296)
2e1a027 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): add support for python 3.11 (#296)
8efe579 
Source-Link: googleapis/synthtool@7197a00
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-talent to v2.7.2 (#296)
cffc726
parthea pushed a commit that referenced this pull request Jul 6, 2023
@renovate-bot
chore(deps): update dependency google-auth to v2.6.3 (#296)
24f6310
parthea added a commit that referenced this pull request Aug 15, 2023
@parthea
chore: prepare for monorepo migration (#296)
1cff7d1
parthea added a commit that referenced this pull request Sep 20, 2023
@kchertenko @nicain @parthea
chore(samples): fix path to products files. (#296)
4e8efb0 
* fix: fix path to products files.

* Fix path creation. Move gcs bucket creation logic to the function.

Co-authored-by: nicain <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#296)
4f18c55 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow to v2.2.0 (#296)
11753b1
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
feat: add cloud spanner connection properties - serverless analytics (#…
44fa6cb 
…296)

* feat: add cloud spanner connection properties - serverless analytics
feat: add cloud spanner connection properties - database role

PiperOrigin-RevId: 511807110

Source-Link: googleapis/googleapis@a563815

Source-Link: googleapis/googleapis-gen@a28f65a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTI4ZjY1YWNhY2UxMjUwNGRmZTQ0OGIyYmRjNTUxM2VlODk4NjI2NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Fixed Ruby documentation generation

PiperOrigin-RevId: 512672271

Source-Link: googleapis/googleapis@bc22d91

Source-Link: googleapis/googleapis-gen@cad484d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2FkNDg0ZDRkYmRjNDM0YmFiOWJkZWIxN2NkZDA3ODQ1N2M3YzcwZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
9a86bb7 
…[autoapprove] (#296)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.53.4 (#296)
21f2730 
- [ ] Regenerate this pull request now.

docs: list oneofs in docstring
fix(deps): require google-api-core >= 1.28.0
fix(deps): drop packaging dependency

committer: busunkim96@
PiperOrigin-RevId: 406468269

Source-Link: googleapis/googleapis@83d81b0

Source-Link: googleapis/googleapis-gen@2ff001f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: added deidentify replacement dictionaries (#296)
b96c13d 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413780624

Source-Link: googleapis/googleapis@ed9918e

Source-Link: googleapis/googleapis-gen@9286ba6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTI4NmJhNjBlMWMxZjZiY2Q1NTllOTgzNDc1NmIyZmEzZTUxZjI2ZCJ9

feat: added field for BigQuery inspect template inclusion lists 
feat: added field to support infotype versioning
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore: release 3.4.0 (#297)
71c0e90 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/python-dlp/compare/v3.3.1...v3.4.0) (2021-12-03)


### Features

* added deidentify replacement dictionaries ([#296](https://www.github.com/googleapis/python-dlp/issues/296)) ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field for BigQuery inspect template inclusion lists ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
* added field to support infotype versioning ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt [autoa…
d46a84f 
…pprove] (#296)

Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): update .kokoro/requirements.txt (#296)
97ab28b 
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 3.6.0 (#296)
dea753e 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.6.0](https://www.github.com/googleapis/python-asset/compare/v3.5.0...v3.6.0) (2021-09-24)


### Bug Fixes

* add 'dict' annotation type to 'request' ([79a5a8a](https://www.github.com/googleapis/python-asset/commit/79a5a8a11d49c52162b9467e291df38f70634858))

### Documentation

* add relationship samples ([#293](https://www.github.com/googleapis/python-asset/issues/293)) ([473e133](https://www.github.com/googleapis/python-asset/commit/473e133e2674bf6a5ae655fe67be7d79fed2d8e9))


---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): add missing import for prerelease testing (#296)
1993c00 
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.56.2 (#296)
f75fa9b 
* chore: update Java and Python dependencies

PiperOrigin-RevId: 408420890

Source-Link: googleapis/googleapis@2921f9f

Source-Link: googleapis/googleapis-gen@6598ca8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): Noxfile recognizes that tests can live in a folder (#296)
0965b0c 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
chore: configure release-please to use manifest (#296)
ab8f72a
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: regenerate samples (#296)
0188124 
* feat: Add an enum value for raw locations from Apple platforms

PiperOrigin-RevId: 476961484

Source-Link: googleapis/googleapis@695134b

Source-Link: googleapis/googleapis-gen@49457f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDk0NTdmOWU3YWFlODljZmUwNDkxYWY0ZGJkOTk2MWE5MDEyNWQzMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 22, 2023
@parthea
chore: update .repo-metadata.json (#296)
038e9c2
parthea pushed a commit that referenced this pull request Oct 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-trace to v1.10.0 (#296)
cd8b4ba
parthea pushed a commit that referenced this pull request Jan 10, 2025
@gcf-owl-bot
chore: Update gapic-generator-python to v1.18.0 (#296)
00addac 
* chore: Update gapic-generator-python to v1.18.0

PiperOrigin-RevId: 638650618

Source-Link: googleapis/googleapis@6330f03

Source-Link: googleapis/googleapis-gen@44fa4f1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
@kolea2
chore(revert): Revert "chore: prevent normalization of semver version…
52eaeca 
…ing (#292)" (#296)

This reverts commit 05bc9aa0
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build(python): release script update (#296)
7d203a3 
Source-Link: googleapis/synthtool@71a7297
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
624c6d7 
…296)

Source-Link: googleapis/synthtool@395d53a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 2.2.1 (#296)
b567d0b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 1.3.1 (#296)
957a8c8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency google-cloud-logging to v2.4.0 (#296)
47e55a7
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: Preserve QueryIterator.cursor_after. (#296)
512606f 
In an overabundance of caution, we were deleting `cursor_after` from
QueryIterator after exhausting the iterator. This was found to differ
from the original implementation, however, and break some customer's
code.

Fixes #292
parthea pushed a commit that referenced this pull request Nov 25, 2025
@renovate-bot
chore(deps): update dependency google-cloud-logging to v2.4.0 (#296)
6320918
parthea pushed a commit that referenced this pull request Nov 26, 2025
@crwilcox @theacodes
Update link to documentation for default credentials (#296)
b027663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucemia @coveralls @tseaver @dhermes @silvolu