Only using explicit namespace when deserializing key pb. #292

dhermes · 2014-10-23T23:44:55Z

This issue surfaced during review for #282.

This issue surfaced during review for googleapis#282.

coveralls · 2014-10-23T23:53:29Z

Coverage remained the same when pulling 12695c2 on dhermes:unmarshall-key-namespace into b6d3e74 on GoogleCloudPlatform:master.

gcloud/datastore/helpers.py

This is to ensure that values are correctly ignored when the field isn't set on the protobuf.

dhermes · 2014-10-24T17:04:46Z

Tests updated. PTAL.

coveralls · 2014-10-24T17:17:02Z

Coverage remained the same when pulling 156c317 on dhermes:unmarshall-key-namespace into b6d3e74 on GoogleCloudPlatform:master.

Only using explicit namespace when deserializing key pb.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…292) Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1

…rors. (#292) Co-authored-by: Anthonios Partheniou <[email protected]>

#292) * feat(Transcoder): update captions code samples for display name and language * test bucket should be deleted * Trigger Build

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392

fix(deps): require proto-plus >= 1.22.0

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472561635 Source-Link: googleapis/googleapis@332ecf5 Source-Link: googleapis/googleapis-gen@4313d68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9

Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@c5026b3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…[autoapprove] (#292) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

Test the minimum supported dependencies in python 3.7 unit tests to prepare for dropping python 3.6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

fix: Add dict typing for client_options chore: update to gapic-generator-python 1.5.0 chore: use autogenerated setup.py - [ ] Regenerate this pull request now. PiperOrigin-RevId: 484665853 Source-Link: https://togithub.com/googleapis/googleapis/commit/8eb249a19db926c2fbc4ecf1dc09c0e521a88b22 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c8aa327b5f478865fc3fd91e3c2768e54e26ad44 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* add progress bar * update changelog * default to use the progress bar

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

…ing (#292)" (#296) This reverts commit 05bc9aa0

Source-Link: googleapis/synthtool@bef813d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94bb690db96e6242b2567a4860a94d48fa48696d092e51b0884a1a2c0a79a407 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.20.0](googleapis/proto-plus-python@v1.19.9...v1.20.0) (2022-02-07) ### Features * add custom __dir__ for messages and message classes ([#289](googleapis/proto-plus-python#289)) ([35e019e](googleapis/proto-plus-python@35e019e)) ### Bug Fixes * workaround for buggy pytest ([#291](googleapis/proto-plus-python#291)) ([28aa3b2](googleapis/proto-plus-python@28aa3b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

FBO checkers which need to verify default values for 'retry' / 'timeout'

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.2](https://www.github.com/googleapis/python-api-core/compare/v2.2.1...v2.2.2) (2021-11-02) ### Bug Fixes * make 'gapic_v1.method.DEFAULT' a typed object ([#292](https://www.github.com/googleapis/python-api-core/issues/292)) ([ffc51f0](https://www.github.com/googleapis/python-api-core/commit/ffc51f03c7ce5d9f009ba859b8df385d52925578)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Jim Fulton <[email protected]>

) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

* chore: Adds python eol deprecation warning * add warnings module * includes sys_micro

In an overabundance of caution, we were deleting `cursor_after` from QueryIterator after exhausting the iterator. This was found to differ from the original implementation, however, and break some customer's code. Fixes #292

Only using explicit namespace when deserializing key pb.

12695c2

This issue surfaced during review for googleapis#282.

dhermes mentioned this pull request Oct 24, 2014

Implements group_by, projection and offset on datastore Query. #282

Merged

tseaver reviewed Oct 24, 2014
View reviewed changes

gcloud/datastore/helpers.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Adding checks for namespace in datastore helpers test.

156c317

This is to ensure that values are correctly ignored when the field isn't set on the protobuf.

dhermes mentioned this pull request Oct 26, 2014

Functional test - Add datastore query tests #281

Merged

dhermes added the api: datastore Issues related to the Datastore API. label Oct 27, 2014

tseaver added a commit that referenced this pull request Oct 27, 2014

Merge pull request #292 from dhermes/unmarshall-key-namespace

f7d0441

Only using explicit namespace when deserializing key pb.

tseaver merged commit f7d0441 into googleapis:master Oct 27, 2014

dhermes deleted the unmarshall-key-namespace branch October 27, 2014 18:03

dhermes mentioned this pull request Oct 27, 2014

Makes operator checking deterministic in Query.filter. #294

Merged

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.8.0 (#292)

52707c2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-storage to v2.2.0 (#292)

072aa83

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 3.7.0 (#292)

d0165f8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 20, 2023

fix: add an error message on user environment setup in case of any er…

79c5bb7

…rors. (#292) Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Sep 20, 2023

feat(Transcoder): update captions code samples for display name and l… (

529d738

#292) * feat(Transcoder): update captions code samples for display name and language * test bucket should be deleted * Trigger Build

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore: release 2.2.0 (#292)

b548953

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 22, 2023

fix(deps): allow protobuf < 5.0.0 (#292)

e87d1b3

fix(deps): require proto-plus >= 1.22.0

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update all dependencies (#292)

ac229b9

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.7.3 (#292)

59e2deb

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-storage to v1.42.2 (#292)

48cd120

parthea added a commit that referenced this pull request Oct 21, 2023

chore: test minimum dependencies in python 3.7 (#292)

aec0bf6

Test the minimum supported dependencies in python 3.7 unit tests to prepare for dropping python 3.6

parthea added a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.8.1 (#292)

e19b69a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.0 (#292)

4affa64

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-automl to v2.5.2 (#292)

e2c7689

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-data to v0.14.0 (#292)

eeb2eda

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 1.9.1 (#292)

a98b61b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(python): rename default branch to main (#292)

4ae7674

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(python): rename default branch to main (#292)

58aa98a

parthea pushed a commit that referenced this pull request Sep 18, 2025

ENH: show progress bar when downloading data (#292)

95c2fff

* add progress bar * update changelog * default to use the progress bar

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore: prevent normalization of semver versioning (#292)

70d7b1f

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore(revert): Revert "chore: prevent normalization of semver version…

52eaeca

…ing (#292)" (#296) This reverts commit 05bc9aa0

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: make 'gapic_v1.method.DEFAULT' a typed object (#292)

c1500c8

FBO checkers which need to verify default values for 'retry' / 'timeout'

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency tqdm to v4.62.2 (#292)

42f3bb5

Co-authored-by: Jim Fulton <[email protected]>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: Adds python eol deprecation warning (#292)

ab7b48b

* chore: Adds python eol deprecation warning * add warnings module * includes sys_micro

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: improve API compatibility for next release (#292)

84d29f0

parthea pushed a commit that referenced this pull request Nov 25, 2025

fix: improve API compatibility for next release (#292)

400daa4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only using explicit namespace when deserializing key pb. #292

Only using explicit namespace when deserializing key pb. #292

Uh oh!

dhermes commented Oct 23, 2014

Uh oh!

coveralls commented Oct 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 24, 2014

Uh oh!

coveralls commented Oct 24, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Only using explicit namespace when deserializing key pb. #292

Only using explicit namespace when deserializing key pb. #292

Uh oh!

Conversation

dhermes commented Oct 23, 2014

Uh oh!

coveralls commented Oct 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 24, 2014

Uh oh!

coveralls commented Oct 24, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants