Update reference to bounds. #2833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
Cancelled CI since it's just a docs change. |
tseaver
reviewed
Dec 7, 2016
| >>> landmarks[0].bounds.vertices[0].x_coordinate | ||
| 78 | ||
| >>> landmarks[0].bounding_poly.vertices[0].y_coordinate | ||
| >>> landmarks[0].bounds.vertices[0].y_coordinate |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
10 tasks
dhermes
approved these changes
Dec 8, 2016
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM but please for the love of crepes stop doing things like
landmarks[0].bounds.vertices[0].x_coordinate
Contributor
Author
|
Yeah, I'm trying to clean those up as I go. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…te-for-landmark Update reference to bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2753
Old references to
bounding_poly->bounds.