Remove speech package not yet released warning. #2732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
14 tasks
Contributor
|
Seems like we shouldn't merge this PR until we have actually pushed a release to PyPI. |
daspecster
added
the
do not merge
Contributor
Author
|
@tseaver, actually probably just before right? |
Contributor
I was figuring that he sdist/bdist_wheel distributions don't contain the docs, so there is no particular reason to have them tell "proactive truth": the only people who will see the docs changes will be looking at |
Contributor
|
This discussion luckily culminates in #2733! |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…speech-warning Remove speech package not yet released warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last checkbox for releasing was to remove the warning about
google-cloud-speechnot being available on PyPI.Do not merge until after release to PyPI.