Pass headers for streaming download. #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
added
the
do not merge
daspecster
force-pushed
the
fix-storage-stream-encrypted-download
branch
from
369034c to
14ce0b1
Compare
daspecster
added
type: bug
tseaver
suggested changes
Nov 14, 2016
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
LGTM after backing out the copyright year change.
system_tests/storage.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2014 Google Inc. | |||
| # Copyright 2016 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Nov 14, 2016
daspecster
force-pushed
the
fix-storage-stream-encrypted-download
branch
from
2c88c61 to
0c77284
Compare
Contributor
Author
|
Squashed. |
Contributor
Author
|
CircleCI passed so I'm going to merge. This run was just post squishing. |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…-encrypted-download Pass headers for streaming download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715