Migrate datastore iterator to use base iterator class #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
reviewed
Nov 8, 2016
| Using the query iterator's | ||
| :meth:`~google.cloud.datastore.query.Iterator.next_page` method: | ||
| Using the query iterator |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
migrate-datastore-iterator
branch
2 times, most recently
from
22578a8 to
0bc7682
Compare
Contributor
|
@dhermes thanks, the same is clear and doesn't make a common use case too difficult. I'm cool with this. |
Removing an unused import and also adding a class-level attribute for ``next_page_token`` which gets set outside of the constructor (Pylint seems to miss the fact that it gets set in the constructor of the base class).
dhermes
force-pushed
the
migrate-datastore-iterator
branch
from
0bc7682 to
7a97e00
Compare
Contributor
Author
|
@daspecster @tseaver PTAL |
daspecster
reviewed
Nov 8, 2016
| >>> query_iter.next_page_token is None | ||
| True | ||
| Under the hood this is doing: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster
approved these changes
Nov 8, 2016
Contributor
daspecster
left a comment
daspecster
left a comment
There was a problem hiding this comment.
This LGTM to me as well.
Contributor
Author
|
Going to merge ( |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…rator Migrate datastore iterator to use base iterator class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered
offsetandend_cursorread-only public properties on the subclass@propertyaliasstart_cursorthat just returns the value ofnext_page_token@propertyaliaslimitthat just returns the value ofmax_resultsI elected not to make anything new public since the original implementation didn't.
@jonparrott PTAL as well (do you think this will be too jarring a change?).