Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 4, 2016

Fixes #2631. @jonparrott I'm not sure if your work makes this a temporary fix or a permanent one?

Also, some of these unit tests I just edited definitely made me shudder ¯\_(ツ)_/¯

/cc @bjwatson

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2016
@theacodes
Copy link
Contributor

theacodes commented Nov 4, 2016

If you just wait for the next release of gax you can just pass credentials instead of creating a channel.

This over-rides the default behavior within GAX, which uses
application default credentials.
@dhermes
Copy link
Contributor Author

dhermes commented Nov 4, 2016

As discussed earlier today, a release of GAX may take too long to wait, but I look forward to deleting this code.

@dhermes dhermes merged commit 0516837 into googleapis:master Nov 4, 2016
@dhermes dhermes deleted the fix-2631 branch November 4, 2016 20:12
daspecster added a commit to daspecster/google-cloud-python that referenced this pull request Nov 4, 2016
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Explicitly passing a channel to GAPIC-generated API classes
parthea pushed a commit that referenced this pull request Nov 24, 2025
Explicitly passing a channel to GAPIC-generated API classes
parthea pushed a commit that referenced this pull request Nov 24, 2025
Explicitly passing a channel to GAPIC-generated API classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gax pubsub ignores custom service account credentials and fetchs ADC instead

5 participants