Use Transcript object in sync and async. #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

daspecster merged 1 commit into googleapis:master from daspecster:add-speech-transcript

Oct 25, 2016

Contributor

daspecster commented Oct 25, 2016

In the spirit of smaller PRs. I started switching sync to GAPIC again and I realized that this is required first.

daspecster added the api: speech label

daspecster assigned tseaver and dhermes

googlebot added the cla: yes label

daspecster mentioned this pull request

Tracking Speech API development. #2522

Closed

14 tasks

dhermes reviewed

View reviewed changes

Contributor

dhermes left a comment

Mostly LGTM, though ping me once issues resolved

speech/google/cloud/speech/client.py

    
              from google.cloud.speech.encoding import Encoding

              from google.cloud.speech.operation import Operation

              from google.cloud.speech.sample import Sample

              from google.cloud.speech.transcript import Transcript

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/client.py Outdated

    
                          return api_response['results'][0]['alternatives']

                          return [Transcript.from_api_repr(alternative)

                                  for alternative

                                  in api_response['results'][0]['alternatives']]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/transcript.py Outdated

    
                  def from_api_repr(cls, transcript):

                      """Factory: construct ``Transcript`` from JSON response.

                      :type transcript: :class:`~SpeechRecognitionAlternative`

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/transcript.py

    
                      :rtype: :class:`~Transcript`

                      :returns: Instance of ``Transcript``.

                      """

                      return cls(transcript['transcript'], transcript['confidence'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

speech/unit_tests/test_client.py

    
                      self.assertEqual(response, expected)

                      alternative = SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0]

                      expected = [Transcript.from_api_repr(alternative)]

                      self.assertIsInstance(response[0], Transcript)

This comment was marked as spam.

Sign in to view

speech/unit_tests/test_client.py Outdated

    
                      expected = [Transcript.from_api_repr(alternative)]

                      self.assertIsInstance(response[0], Transcript)

                      self.assertEqual(response[0].transcript, expected[0].transcript)

                      self.assertEqual(response[0].confidence, expected[0].confidence)

This comment was marked as spam.

Sign in to view

speech/unit_tests/test_client.py Outdated

    
                          SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0])]

                      self.assertIsInstance(response[0], Transcript)

                      self.assertEqual(response[0].transcript, expected[0].transcript)

                      self.assertEqual(response[0].confidence, expected[0].confidence)

This comment was marked as spam.

Sign in to view

dhermes approved these changes

View reviewed changes

Contributor

dhermes left a comment

LGTM pending my two nits and length checks. Feel free to incorporate my feedback about the results[0] bit, but don't feel required to.

speech/unit_tests/test_client.py Outdated

    
                      alternative = SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0]

                      expected = [Transcript.from_api_repr(alternative)]

                      expected = Transcript.from_api_repr(alternative)

                      self.assertEqual(len(response, 1))

This comment was marked as spam.

Sign in to view

speech/google/cloud/speech/client.py Outdated

    
                      if len(api_response['results']) == 1:

                      results = api_response['results']

                      if len(results) == 1:

                          result = results[0]['alternatives']

This comment was marked as spam.

Sign in to view

speech/unit_tests/test_client.py

    
                      expected = [Transcript.from_api_repr(

                          SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0])]

                      expected = Transcript.from_api_repr(

                          SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0])

This comment was marked as spam.

Sign in to view


          Use Transcript object in sync and async.

325cbe7

daspecster force-pushed the add-speech-transcript branch from c90f33a to 325cbe7 Compare

October 25, 2016 21:32

Contributor Author

daspecster commented Oct 25, 2016

Ok thanks! I changed the response check via your suggestion, added the length check and fixed my bug.

I also just squashed the commits.

Contributor Author

daspecster commented Oct 25, 2016

Travis is green. Merging.

daspecster merged commit 0f8fdb6 into googleapis:master

daspecster deleted the add-speech-transcript branch

October 25, 2016 21:37

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request


          Merge pull request googleapis#2613 from daspecster/add-speech-transcript

195c4ef

Use Transcript object in sync and async.

theacodes unassigned dhermes

atulep pushed a commit that referenced this pull request


          Merge pull request #2613 from daspecster/add-speech-transcript

9503fb4

Use Transcript object in sync and async.

atulep pushed a commit that referenced this pull request


          Merge pull request #2613 from daspecster/add-speech-transcript

e7032b3

Use Transcript object in sync and async.

parthea pushed a commit that referenced this pull request


          Automl ga base samples [(#2613)](GoogleCloudPlatform/python-docs-samp…

79f2763

…les#2613)

* automl: add base samples

* automl: add base set of samples

* Clean up tests

* License year 2020, drop python2 print statement unicode

* use centralized automl testing project

* Fix GCS path typo

* Use fake dataset for batch predict

* lint: line length

* fix fixture naming and use

* Fix fixture changes

* Catch resource exhausted error

* use fake data for import test

* update how to access an operation id

Co-authored-by: Leah E. Cole <[email protected]>

parthea pushed a commit that referenced this pull request


          Merge pull request #2613 from daspecster/add-speech-transcript

Use Transcript object in sync and async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: speech cla: yes