Use MessageToDict in logging._gax #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces lots of ad-hoc conversion code.
Also replacing _struct_pb_to_mapping with MessageToDict and removing the unused _value_pb_to_value (wasn't showing up in uncovered code / non-linted code since it was fully unit tested).
googlebot
added
the
cla: yes
Contributor
Author
|
@tseaver FYI >>> from google.protobuf.json_format import ParseDict
>>> from google.logging.type.http_request_pb2 import HttpRequest
>>> ParseDict({'request_url': 'a'}, HttpRequest())
request_url: "a"
>>> ParseDict({'requestUrl': 'a'}, HttpRequest())
request_url: "a" |
Contributor
|
Here's a link to |
tseaver
reviewed
Oct 25, 2016
| mapping['operation'], entry_pb.operation) | ||
|
|
||
| mapping['timestamp'] = _datetime_to_rfc3339(mapping['timestamp']) | ||
| ParseDict(mapping, entry_pb) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| # Import the wrappers to register the type URL for BoolValue | ||
| # pylint: disable=unused-variable | ||
| from google.protobuf import wrappers_pb2 | ||
| # pylint: enable=unused-variable |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tseaver Any remaining issues? |
Contributor
|
LGTM |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…getodict Use MessageToDict in logging._gax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removal of lots of custom conversion code. I noticed this when doing #2589.