Removing Iterator.reset(). #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in advance of supporting GAX page iterators within our Iterator class. Iterator.reset() isn't a feature that a typical Python user expects to exist, and restarting an iterator can be as easy as: >>> my_iter = client.list_foo(*args, **kwargs) >>> consume_it(my_iter) >>> restarted_iter = client.list_foo(*args, **kwargs)
googlebot
added
the
cla: yes
Contributor
>>> my_iter = client.list_foo(*args, **kwargs)
>>> consume_it(my_iter)
>>> restarted_iter = client.list_foo(*args, **kwargs) # API call.
>>> my_iter.reset() # No API call.I don't know if that matters? Supporting GAX page iterators is a bigger benefit over making an extra API call I would think. |
Contributor
Author
|
@daspecster It's not about API calls, it's about not being able to re-set to the initial state for a GAX iterator. And calling |
theacodes
approved these changes
Oct 24, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Removing Iterator.reset().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in advance of supporting GAX page iterators within our Iterator class.
Iterator.reset()isn't a feature that a typical Python user expects to exist, and restarting an iterator can be as easy as: