Fix #121: Drop munging of 's~' prefix onto keys. #259

tseaver · 2014-10-17T16:36:19Z

Fixes #121.

Note: may conflict with PR #257 and #258.

dhermes · 2014-10-17T16:38:55Z

This LGTM but I'd be more comfortable having @pcostell or @proppy take a look before we merge.

coveralls · 2014-10-17T16:44:18Z

Coverage remained the same when pulling 538084d on tseaver:121-drop_dataset_prefixes_in_keys into 906700b on GoogleCloudPlatform:master.

tseaver · 2014-10-17T20:11:26Z

Sure. The patch is based on @pcostell's feedback in #121.

silvolu · 2014-10-20T18:00:37Z

LGTM, we've made a similar fix in gcloud-node. I'm happy to merge if the change is rebased.

Fixes #121. Note: may conflict with PR #257 and #258.

tseaver · 2014-10-20T19:40:26Z

Rebased to address merge conflicts.

Fix #121: Drop munging of 's~' prefix onto keys.

tseaver · 2014-10-20T22:25:07Z

@pcostell @silvolu this change breaks access to the API. For instance:

$ python -m gcloud.datastore.demo

# pragma NO COVER
# Welcome to the gCloud Datastore Demo! (hit enter) 

# We're going to walk through some of the basics...
# Don't worry though. You don't need to do anything, just keep hitting enter... 

# Let's start by importing the demo module and getting a dataset: 
>>> from gcloud.datastore import demo
>>> dataset = demo.get_dataset()

# Let's create a new entity of type "Thing" and name it 'Toy': 
>>> toy = dataset.entity('Thing')
>>> toy.update({'name': 'Toy'})

# Now let's save it to our datastore: 
>>> toy.save()
Traceback (most recent call last):
File "/opt/Python-2.7.6/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
File "/opt/Python-2.7.6/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
File "/home/tseaver/projects/agendaless/Google/src/gcloud-python/gcloud/datastore/demo/__main__.py", line 5, in <module>
    demo.DemoRunner.from_module(datastore).run()
File "gcloud/demo.py", line 34, in run
    self.code(lines)
File "gcloud/demo.py", line 102, in code
    self._execute_lines(code_lines)
File "gcloud/demo.py", line 109, in _execute_lines
    exec('\n'.join(lines), self.GLOBALS, self.LOCALS)
File "<string>", line 1, in <module>
File "gcloud/datastore/entity.py", line 225, in save
    properties=dict(self))
File "gcloud/datastore/connection.py", line 384, in save_entity
    result = self.commit(dataset_id, mutation)
File "gcloud/datastore/connection.py", line 337, in commit
    datastore_pb.CommitResponse)
File "gcloud/datastore/connection.py", line 81, in _rpc
    data=request_pb.SerializeToString())
File "gcloud/datastore/connection.py", line 59, in _request
    raise Exception('Request failed. Error was: %s' % content)
Exception: Request failed. Error was: app s~gcloud-datastore-demo cannot access app gcloud-datastore-demo&#39;s data

pcostell · 2014-10-20T22:31:47Z

Ah the problem looks like where you removed the munging:

When you connect to the dataset, you should only use the project-id (i.e. name without s~).

When you use that dataset to get/put, the keys involved should leave the dataset empty to get the correct dataset.

tseaver · 2014-10-20T22:49:36Z

@pcostell We were never adding the 's~' prefix to the dataset object's own ID: we only added it to the 'partition_id.dataset_id' field in the protobuf generated for each key. Do you mean that we should leave 'partition_id.dataset_id' empty for keys created de novo? I presume we would preserve whatever the server sets for keys returned from lookup / query operations.

pcostell · 2014-10-20T23:02:27Z

@tseaver That's correct. If you've been given the correct dataset_id (generally from the backend) it's ok to leave it as is. Otherwise, you should drop the entire dataset. The backend will see the empty dataset and fill it in with the dataset for the current application.

tseaver · 2014-10-21T17:59:03Z

@pcostell looking at the gcloud-node fix, it appears we could just avoid copying the dataset ID into the key protobuf altogether, i.e., deleting these lines.

Does that seem correct? If not, I'm not sure how to distinguish the "set from the backend" dataset IDs from the ones passed in from the environment / configuration.

pcostell · 2014-10-21T18:09:27Z

Could you leave that in so that provided datasets don't get erased but then
change this:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/fab02378b3facca8ca290b4c0f52732f2a47181a/gcloud/datastore/entity.py#L72

So that when it creates a new entity it doesn't force the dataset of the
key?

If that won't work, not copying the dataset ID at all SGTM. I think the
only problem is if you want to store a key that belongs to a different
dataset. However, Cloud Datastore is working on making that easier so it
could be good enough to disallow that use case until the backend has better
support.

On Tue Oct 21 2014 at 10:59:07 AM Tres Seaver [email protected]
wrote:

@pcostell https://github.com/pcostell looking at the gcloud-node fix
googleapis/google-cloud-node#97, it appears
we could just avoid copying the dataset ID into the key protobuf
altogether, i.e., deleting these lines
https://github.com/GoogleCloudPlatform/gcloud-python/blob/fab02378b3facca8ca290b4c0f52732f2a47181a/gcloud/datastore/key.py#L94-L100
.

Does that seem correct? If not, I'm not sure how to distinguish the "set
from the backend" dataset IDs from the ones passed in from the environment
/ configuration.

—
Reply to this email directly or view it on GitHub
#259 (comment)
.

- [ ] Regenerate this pull request now. fix: improper types in pagers generation PiperOrigin-RevId: 399773015 Source-Link: googleapis/googleapis@410c184 Source-Link: googleapis/googleapis-gen@290e883 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * add owlbot.py to exclude generated gapic_version.py * set manifest to true in .github/release-please.yml * add release-please-config.json * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…p/templates/python_library/.kokoro (#259) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Add documentation for enums fix: Add context manager return types chore: Update gapic-generator-python to v1.8.1 PiperOrigin-RevId: 503210727 Source-Link: googleapis/googleapis@a391fd1 Source-Link: googleapis/googleapis-gen@0080f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Source-Link: googleapis/synthtool@52aef91 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(samples): Adding samples for suspend/resume * Fixing lint problems

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

- [ ] Regenerate this pull request now. fix: improper types in pagers generation PiperOrigin-RevId: 399773015 Source-Link: googleapis/googleapis@410c184 Source-Link: googleapis/googleapis-gen@290e883 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9

#259) Source-Link: googleapis/synthtool@7fd61f8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4ee57a76a176ede9087c14330c625a71553cf9c72828b2c0ca12f5338171ba60 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.13.1](googleapis/python-analytics-data@v0.13.0...v0.13.1) (2022-07-19) ### Documentation * **samples:** add runFunnelReport sample ([#258](googleapis/python-analytics-data#258)) ([af9d130](googleapis/python-analytics-data@af9d130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* chore: Update gapic-generator-python to v1.11.7 PiperOrigin-RevId: 573230664 Source-Link: googleapis/googleapis@93beed3 Source-Link: googleapis/googleapis-gen@f4a4eda Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhNGVkYWE4MDU3NjM5ZmNmNmFkZjkxNzk4NzIyODBkMWE4ZjY1MSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.8 PiperOrigin-RevId: 574178735 Source-Link: googleapis/googleapis@7307199 Source-Link: googleapis/googleapis-gen@ce3af21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UzYWYyMWI3YzU1OWE4N2MyYmVmYzA3NmJlMGUzYWVkYTNhMjZmMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.11.9 PiperOrigin-RevId: 574520922 Source-Link: googleapis/googleapis@5183984 Source-Link: googleapis/googleapis-gen@a59af19 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5YWYxOWQ0YWM2NTA5ZmFlZGYxY2MzOTAyOTE0MWI2YTViODk2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update docs/index.rst;remove unused files * update docs/index.rst * fix docs build to cater for types_ --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@352b9d4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. fix: improper types in pagers generation PiperOrigin-RevId: 399773015 Source-Link: googleapis/googleapis@410c184 Source-Link: googleapis/googleapis-gen@290e883 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…259) * DOC: Update "writing" docs with information about schema inference. This commit started as a clean-up change to remove the unnecessary pandas_gbq.gbq._update_bq_schema method, but I then also updated the docs for to_gbq to be more clear about how the table_schema argument is to be used. I added a section to the writing.rst how-to guide about the table_schema parameter as well. Some of the "notes" in writing.rst were better as their own subsections. I moved the note on not to use BigQuery as a transactional database to the landing page. I link to the BigQuery sandox docs in the warning about creating a BigQuery account because you can follow those instructions to use BigQuery without entering credit card information. * Blacken

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: add grpc transcoding + tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: tweak for clarity / idiomatic usage * chore: attempt to appease Sphinx * feat: add grpc transcoding + tests * Add functions to properly handle subfields * Add unit tests for get_field and delete_field. * Add function docstrings and incorporate correct native dict functions. * Add function docstrings and incorporate correct native dict functions. * Increase code coverage * Increase code coverage * Increase code coverage * Reformat files Co-authored-by: Yonatan Getahun <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tres Seaver <[email protected]>

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Closes #266 Closes #265 Closes #263 Closes #262 Closes #261 Closes #260 Closes #259 Closes #258 Closes #256 🦕

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

Drop munging of 's~' prefix onto keys.

82b3b1f

Fixes #121. Note: may conflict with PR #257 and #258.

tseaver added api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 20, 2014

tseaver added a commit that referenced this pull request Oct 20, 2014

Merge pull request #259 from tseaver/121-drop_dataset_prefixes_in_keys

88b0ec7

Fix #121: Drop munging of 's~' prefix onto keys.

tseaver merged commit 88b0ec7 into googleapis:master Oct 20, 2014

tseaver deleted the 121-drop_dataset_prefixes_in_keys branch October 20, 2014 20:29

tseaver mentioned this pull request Oct 20, 2014

datastore: default to empty dataset #121

Closed

dhermes mentioned this pull request Oct 21, 2014

Functional test part1 #273

Merged

tseaver mentioned this pull request Oct 21, 2014

Revert "Fix #121: Drop munging of 's~' prefix onto keys." #274

Merged

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Added attribute size to attachments googleapis#259

f358a81

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.9.1 (#259)

af6eef5

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: release 2.6.0 (#259)

36e9526

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

docs(samples): Add samples for suspending/resuming an instance (#259)

48c82d7

* chore(samples): Adding samples for suspend/resume * Fixing lint problems

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#259)

0424f1f

parthea added a commit that referenced this pull request Oct 21, 2023

chore: update .repo-metadata.json (#259)

342e4a7

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: fail samples nox session if python version is missing (#259)

c518319

parthea pushed a commit that referenced this pull request Oct 31, 2023

chore(main): release 2.10.0 (#259)

1a41624

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

Update version in setup.py to 0.14.0 (#259)

169381d

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 1.19.3 (#259)

d74c791

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Nov 24, 2025

chore: update .repo-metadata.json (#259)

ff199e5

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: prevent normalization of semver versioning (#259)

c8a9926

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: prevent normalization of semver versioning (#259)

cb08c9a

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore: prevent normalization of semver versioning (#259)

4d47b7e

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore: prevent normalization of semver versioning (#259)

cc51599

* chore: prevent normalization of semver versioning * chore: update workaround to make sic work

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #121: Drop munging of 's~' prefix onto keys. #259

Fix #121: Drop munging of 's~' prefix onto keys. #259

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

silvolu commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

pcostell commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

pcostell commented Oct 20, 2014

Uh oh!

tseaver commented Oct 21, 2014

Uh oh!

pcostell commented Oct 21, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix #121: Drop munging of 's~' prefix onto keys. #259

Fix #121: Drop munging of 's~' prefix onto keys. #259

Uh oh!

Conversation

tseaver commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

silvolu commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

pcostell commented Oct 20, 2014

Uh oh!

tseaver commented Oct 20, 2014

Uh oh!

pcostell commented Oct 20, 2014

Uh oh!

tseaver commented Oct 21, 2014

Uh oh!

pcostell commented Oct 21, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants