Fix #167: Update docstring for 'Connection.save_entity'. #258

tseaver · 2014-10-17T16:05:00Z

Indicate that upsert clears existing properties before applying those passed to the API.

Fixes #167.

Indicate that upsert clears existing properties before applying those passed to the API. Fixes #167.

coveralls · 2014-10-17T16:15:08Z

Coverage remained the same when pulling ef53536 on tseaver:167-connection_save_entity into 906700b on GoogleCloudPlatform:master.

gcloud/datastore/connection.py

dhermes · 2014-10-17T16:43:03Z

@tseaver in the interest of closing #4 we should also include an example like JJ's on Entity.save. Most users will likely not ever use Connection.save_entity directly, rather they'll use it through Entity.save. In addition, the current docstring implies that deleting a property will suffice but doesn't make it explicit, so I think we should.

Reinforce that previously-stored properties which don't have values set in the current entity instance will be removed.

coveralls · 2014-10-17T17:25:12Z

Coverage remained the same when pulling 8e40313 on tseaver:167-connection_save_entity into 906700b on GoogleCloudPlatform:master.

dhermes · 2014-10-17T18:22:41Z

LGTM.

Fix #167: Update docstring for 'Connection.save_entity'.

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.9.0 PiperOrigin-RevId: 517425588 Source-Link: googleapis/googleapis@33c93eb Source-Link: googleapis/googleapis-gen@d5f5978 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDVmNTk3ODlkMTlmYzQzMjcwZmYyMTI0OTY3ZDRlYzg5OTJiOGU4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…1.1 (#258)

🤖 I have created a release *beep* *boop* --- ### [1.2.1](googleapis/python-documentai@v1.2.0...v1.2.1) (2022-01-17) ### Bug Fixes * **deps:** drop packaging dependency ([038a736](googleapis/python-documentai@038a736)) * **deps:** require google-api-core >= 1.28.0 ([038a736](googleapis/python-documentai@038a736)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392

* chore: Update gapic-generator-python to v1.11.9 PiperOrigin-RevId: 574520922 Source-Link: googleapis/googleapis@5183984 Source-Link: googleapis/googleapis-gen@a59af19 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5YWYxOWQ0YWM2NTA5ZmFlZGYxY2MzOTAyOTE0MWI2YTViODk2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * migrate to standard owlbot.py * remove unused file * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@7e1f6da Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:a1a891041baa4ffbe1a809ac1b8b9b4a71887293c9101c88e8e255943c5aec2d

….3 (#258)

) Source-Link: googleapis/synthtool@7804ade Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

)

Source-Link: googleapis/synthtool@703554a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b

* docs(samples): add runFunnelReport sample * docs(samples): add runFunnelReport sample * Merge remote-tracking branch 'origin/funnel' into funnel # Conflicts: # samples/snippets/run_funnel_report.py * docs(samples): add runFunnelReport sample * docs(samples): add runFunnelReport sample Co-authored-by: Anthonios Partheniou <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [0.13.1](googleapis/python-analytics-data@v0.13.0...v0.13.1) (2022-07-19) ### Documentation * **samples:** add runFunnelReport sample ([#258](googleapis/python-analytics-data#258)) ([af9d130](googleapis/python-analytics-data@af9d130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. fix: improper types in pagers generation PiperOrigin-RevId: 399773015 Source-Link: googleapis/googleapis@410c184 Source-Link: googleapis/googleapis-gen@290e883 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9

) Source-Link: https://togithub.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

Source-Link: https://togithub.com/googleapis/synthtool/commit/cb960373d12d20f8dc38beee2bf884d49627165e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* read project_id from credentials if available * Move project inference from credentials to shared GbqConnector To more easily test the project ID inference, this commit also sends the project ID as part of the query method call. Even though this is redundant because the client object also contains the project ID, we aren't exercising the bigquery.Client constructor in the unit tests to avoid making real API calls.

The generated method flattening semantics change between the the original monolithic GAPIC generator and this GAPIC generator (aka the Python Microgenerator). User code that calls methods from GAPICs generated by the monolith will need to be converted to use the new flattening semantics. This change describes a template for an automated per-service conversion script. Cases the conversion script will NOT handle correctly include * Dynamic method dispatch * Method calls via an alias or as a free function * Star arg exapnsion in a method call (*args or **kwargs) Plain, normal, vanilla calls are the target for conversion.

…cp/templates/python_library/.kokoro (#258) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Co-authored-by: Tres Seaver <[email protected]>

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Closes #266 Closes #265 Closes #263 Closes #262 Closes #261 Closes #260 Closes #259 Closes #258 Closes #256 🦕

…lates/python_library/.kokoro (#258) Source-Link: googleapis/synthtool@9367caa Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2f155882785883336b4468d5218db737bb1d10c9cea7cb62219ad16fe248c03c Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@fac8444 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@8d392a5 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a0c4463fcfd9893fc172a3b3db2b6ac0c7b94ec6ad458c7dcea12d9693615ac3 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: allow releases on previous major versions * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Fixes: #190

It turns out that `query.ParameterizedFunction` wasn't finished in its implementation. It is meant to deal with the case, in GQL, where GQL functions are called. This PR also adds an implementation for the `LIST` GQL function and stubs for future impelemntations of `USER` and `KEY`. Remaining GQL functions needing to be implemented are unknown at this time. Fixes #258.

Update docstring for 'Connection.save_entity'.

ef53536

Indicate that upsert clears existing properties before applying those passed to the API. Fixes #167.

dhermes reviewed Oct 17, 2014
View reviewed changes

gcloud/datastore/connection.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This was referenced Oct 17, 2014

Fix #121: Drop munging of 's~' prefix onto keys. #259

Merged

Add documentation on how to delete a property from a datastore entity #4

Closed

tseaver mentioned this pull request Oct 17, 2014

Is the logic for datastore.Entity.save() correct? #6

Closed

Update doctstrings for 'Entity.save' and 'Connection.save_entity'.

8e40313

Reinforce that previously-stored properties which don't have values set in the current entity instance will be removed.

tseaver added a commit that referenced this pull request Oct 17, 2014

Merge pull request #258 from tseaver/167-connection_save_entity

be5edde

Fix #167: Update docstring for 'Connection.save_entity'.

tseaver merged commit be5edde into googleapis:master Oct 17, 2014

tseaver deleted the 167-connection_save_entity branch October 17, 2014 19:58

dhermes added api: datastore Issues related to the Datastore API. docs labels Dec 31, 2015

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.9.1 (#258)

f6758e6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.2.0 (#258)

abd30d8

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.10.1 (#258)

eff70aa

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-media-translation to v0.1…

2bcf7e0

…1.1 (#258)

parthea added a commit that referenced this pull request Jun 4, 2023

fix(deps): require protobuf <4.0.0dev (#258)

2ffec6a

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-datacatalog to v3.6.0 (#258)

e71c25a

parthea added a commit that referenced this pull request Jun 4, 2023

docs: fix changelog header to consistent size (#258)

fb83f13

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-containeranalysis to v2.7…

049fa1b

….3 (#258)

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-texttospeech to v2.5.3 (#258

f9aeee9

)

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-vision to v2.6.0 (#258)

7c4c691

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 2.12.0 (#258)

aac3b59

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jan 10, 2025

chore(main): release 1.10.0 (#258)

4e3c522

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: do not error on LROs with no response or error (#258)

bc0debb

Co-authored-by: Tres Seaver <[email protected]>

parthea pushed a commit that referenced this pull request Nov 24, 2025

tests: require 100% unit test coverage (#258)

2bac38b

Fixes: #190

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: Improve source location overrides (#258)

5ac2117

parthea pushed a commit that referenced this pull request Nov 25, 2025

feat: Improve source location overrides (#258)

8940d6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #167: Update docstring for 'Connection.save_entity'. #258

Fix #167: Update docstring for 'Connection.save_entity'. #258

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #167: Update docstring for 'Connection.save_entity'. #258

Fix #167: Update docstring for 'Connection.save_entity'. #258

Uh oh!

Conversation

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants