Skip to content

Capture 'query' attr when loading 'QueryJob' from JSON resource. #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Oct 12, 2016
Merged

Capture 'query' attr when loading 'QueryJob' from JSON resource. #2534

tseaver merged 1 commit into from
Oct 12, 2016
+4 −1

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2016

Closes: #2511.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Oct 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2016
dhermes
dhermes reviewed Oct 12, 2016
View reviewed changes
bigquery/google/cloud/bigquery/job.py
"""
configuration = cleaned['configuration']['query']

self.query = configuration['query']

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 12, 2016

LGTM pending Travis / my teeny comment

@tseaver tseaver merged commit 9c9c126 into googleapis:master Oct 12, 2016
@tseaver tseaver deleted the 2511-bigquery-capture-query-when-loading-job-by-name branch October 12, 2016 17:14
@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#2534 from tseaver/2511-bigquery-capture…
d6121b0 
…-query-when-loading-job-by-name

Capture 'query' attr when loading 'QueryJob' from JSON resource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @dhermes @daspecster @googlebot