Properly encode image content. #2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tseaver
suggested changes
Oct 12, 2016
| image_request = client.connection._requested[0]['data']['requests'][0] | ||
| # json_dump = json.dumps(image_request['image']['content']) | ||
| # self.assertEqual(json_dump, self.B64_IMAGE_CONTENT) | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vision/unit_tests/test_client.py
Outdated
| class TestClient(unittest.TestCase): | ||
| import base64 | ||
| from google.cloud._helpers import _to_bytes | ||
| from google.cloud._helpers import _bytes_to_unicode |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Oct 12, 2016
Contributor
Author
|
@tseaver, I moved the imports and constants for the other test I updated for this. LMKWYT |
tseaver
approved these changes
Oct 12, 2016
daspecster
force-pushed
the
vision-type-error-2525
branch
from
e85c772 to
0e992eb
Compare
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…2525 Properly encode image content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image content was not being properly encoded before being JSON serialized for the request.
Fixes #2525.