-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Speech Python 3.5 encoding content - 'not JSON serializable' #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daspecster
merged 2 commits into
googleapis:master
from
daspecster:fix-encoding-speech-bug-2519
Oct 11, 2016
Merged
Speech Python 3.5 encoding content - 'not JSON serializable' #2520
daspecster
merged 2 commits into
googleapis:master
from
daspecster:fix-encoding-speech-bug-2519
Oct 11, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Oct 9, 2016
speech/google/cloud/speech/client.py
Outdated
| if sample.content is not None: | ||
| audio = {'content': b64encode(_to_bytes(sample.content))} | ||
| audio = {'content': | ||
| b64encode(_to_bytes(sample.content)).decode('ascii')} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
e3fb4a0 to
23a2979
Compare
23a2979 to
9e5b448
Compare
Contributor
|
LGTM |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…h-bug-2519 Speech Python 3.5 encoding content - 'not JSON serializable'
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
Speech Python 3.5 encoding content - 'not JSON serializable'
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
Speech Python 3.5 encoding content - 'not JSON serializable'
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Speech Python 3.5 encoding content - 'not JSON serializable'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: speech
Issues related to the Speech-to-Text API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling bytes when encoding the request content was failing in Python 3.5.
Closes #2519.