Fix #239: remove / document 'pragma: NO COVER' #248

tseaver · 2014-10-16T20:34:29Z

See #239 for discussion.

…s_from_response.

Fixes bug for errno != ENOSPC.

@dhermes

…ed_url. Borrow @dhermes' factoring of '_get_expiration_seconds', but make it a free function rather than a static method, and make the testes more fine-grained.

Suppress coverage for them instead via .coveragerc.

@dhermes

Incorporates feedback from @dhermes.

coveralls · 2014-10-16T20:43:07Z

Coverage decreased (-0.03%) when pulling 84e181e on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

coveralls · 2014-10-16T20:54:47Z

Coverage decreased (-0.03%) when pulling 6497cd3 on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

coveralls · 2014-10-16T20:58:53Z

Coverage remained the same when pulling 6497cd3 on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

@dhermes

Incorporate feedback from @dhermes.

coveralls · 2014-10-16T21:18:45Z

Coverage remained the same when pulling 4c7b14b on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

tseaver · 2014-10-16T21:22:21Z

The cleanup you are referring to in #238:

https://github.com/GoogleCloudPlatform/gcloud-python/pull/238/files#diff-131c11d8f72de47362212af2ee7c7791L871

Doesn't apply here, as the repeated definition is not present on master (or this branch). It could perhaps be factored out of 'gcloud.test_credentials' into something like 'gcloud._testing'.

coveralls · 2014-10-16T21:24:50Z

Coverage remained the same when pulling 4c7b14b on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

tseaver · 2014-10-16T21:29:03Z

I'm pretty displeased with the E124 and related errors pep8 is spitting out by default: there is no obviously-better way to spell assertions comparing data structures that doesn't fall afoul of one
or more of its rules. E.g., even after indenting one more space to the code in https://github.com/tseaver/gcloud-python/blob/63eb552e8d4a4616b60f8e55726cdbf9d098d3c3/gcloud/storage/test_connection.py#L587-L591, I sill ended up rewriting the assertions in 4c7b14b because I couldn't figure it out.

I'd just as soon turn of all their "hanging indent" checks.

dhermes · 2014-10-16T21:35:59Z

RE: E124 see #238 (comment)

The main thrust is that things like

        self.assertEqual(params,
                        {'Signature': [SIGNED],
                         'Expires': ['1000'],
                         'GoogleAccessId': [_Credentials.service_account_name],
                        })

are actually against PEP8 because by having

        self.assertEqual(params,

does not make it a continuation.

To make it valid, it would have to actually be a continuation

        self.assertEqual(
            params,
            {'Signature': [SIGNED],
             'Expires': ['1000'],
             'GoogleAccessId': [_Credentials.service_account_name],
            })

dhermes · 2014-10-16T21:39:31Z

RE: Cleanup, it's on master:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/0e99f7b9cb444eda4b8d35e389d3a838fb2d8aad/gcloud/datastore/test_connection.py#L871
and has been since f6a4306.

tseaver · 2014-10-16T22:01:19Z

Have a look at the examples under: http://legacy.python.org/dev/peps/pep-0008/#indentation

They do not require that the opening paren of a function call be the last character when wrapping. E.g., this is in the "OK" block:

# Aligned with opening delimiter.
foo = long_function_name(var_one, var_two,
                         var_three, var_four)

as is this for data structures:

my_list = [
    1, 2, 3,
    4, 5, 6,
    ]

tseaver · 2014-10-16T22:04:42Z

The redundant '_Monkey' you point to is in 'gcloud.datastore.test_connection', which this PR doesn't touch: it does touch 'gcould.storage.test_connection', but reuses the '_Monkey' from 'gcloud.test_credentials'.

@dhermes

Incorporate feedback from @dhermes.

coveralls · 2014-10-16T22:15:19Z

Coverage remained the same when pulling a6bf98f on tseaver:239-remove_pragma_no_cover into c2c1d59 on GoogleCloudPlatform:master.

tseaver · 2014-10-16T22:19:47Z

See #250, which moves the '_Monkey' class into a new 'gcloud._testing' module (to avoid having one testcase module depend on another).

tseaver · 2014-10-16T22:33:35Z

@dhermes My "arguing with the ref" about pep8 E124 is actually irrelevant to this PR, because I rewrote the problematic statements to avoid it altogether. Are there remaining issues?

dhermes · 2014-10-16T22:34:54Z

Ah yes, good call.

This PR LGTM.

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…on time series tables (#248) * feat: added support for horizontal bar rendering and column settings on time series tables PiperOrigin-RevId: 501316608 Source-Link: googleapis/googleapis@09d97e0 Source-Link: googleapis/googleapis-gen@8085bab Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODA4NWJhYjFiZGY0YjlkNzAwN2RkOTRmNWQ2Yzk3NTg4OGExNGQ3MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

…p/templates/python_library/.kokoro (#248) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@dd05f9d Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:aea14a583128771ae8aefa364e1652f3c56070168ef31beb203534222d842b8b

In order to preserve the interface of legacy client construction, client constructors take a 'google.api_core.client_options.ClientOptions' parameter. Currently, this option only customizes the api endpoint, but other customizations may be enabled. Includes generated unit tests. Implementation for #227

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Fixes #247.

* feat: add api_key to client options * update

This PR fixes an issue with the `owlbot.py` file which prevented [google/cloud/datastore_v1](https://github.com/googleapis/python-datastore/commits/main/google/cloud/datastore_v1) from being updated. This PR also brings the client up to date with the generated client in googleapis-gen [here](https://github.com/googleapis/googleapis-gen/tree/master/google/datastore). chore: update owlbot.py to properly copy folders from googleapis-gen fix(deps): require google-api-core >= 1.28.0 docs: list oneofs in docstring feat: add context manager support in client fix: add 'dict' annotation type to 'request' fix: add async client to %name_%version/init.py feat: support self-signed JWT flow for service accounts feat: Added methods for creating and deleting composite indexes

Source-Link: googleapis/synthtool@d895aec Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:98f3afd11308259de6e828e37376d18867fd321aba07826e29e4f8d9cab56bad Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Adjust Error Reporting branding in documentation In line with product branding guidelines, the product is 'Error Reporting' and can be referred to as 'Google Cloud Error Reporting' when appropriate, but not 'Cloud Error Reporting' fixes #248 * Adjust brand name in repo metadata Co-authored-by: losalex <[email protected]>

* docs: adds UPGRADING.md, not to readme, to help inform users about migration to v2 * docs: erroneous version number * Update UPGRADING.md Co-authored-by: BenWhitehead <[email protected]> * docs: clarify enums statement * docs: add migration section to docs index Co-authored-by: BenWhitehead <[email protected]>

This fixes issues, generally, with the handling of repeated properties with projection queries, but also specifically for the "class" property of PolyModel entities. Fixes #248

tseaver added 10 commits October 16, 2014 13:59

Don't suppress coverage for gcloud.datastore.key.Key.parent.

42f74e9

Add explicit coverage for gcloud.datastore.acl.ACL.get_entities.

b0dcc01

Don't suppress coverage for gcloud.storage.acl.ACL.save.

a1aea7d

Don't suppress coverage for gcloud.storage.iterator.Iterator.get_item…

9583fbe

…s_from_response.

Don't remap (only some) IOError.

9cfb628

Fixes bug for errno != ENOSPC.

Don't suppress coverage for gcloud.storage.key.Key.generate_signed_url.

806d08a

Don't suppress coverage for gcloud.connetion.Connection.generate_sign…

13b0550

…ed_url. Borrow @dhermes' factoring of '_get_expiration_seconds', but make it a free function rather than a static method, and make the testes more fine-grained.

Drop 'pragma: NO COVER' for '__repr__' methods.

a3737e6

Suppress coverage for them instead via .coveragerc.

Document non-coverage of non-testing path through '_utcnow'.

0f3828a

Drop comments replicating docstring info.

84e181e

Incorporates feedback from @dhermes.

Fix fussiness introduced by .coveragerc change.

6497cd3

tseaver added 3 commits October 16, 2014 17:07

Avoid extra 'if _UTCNOW is not None:' check.

868506b

Incorporate feedback from @dhermes.

lint.

63eb552

Dead chickens for pep8 E124.

4c7b14b

Typo.

a6bf98f

Incorporate feedback from @dhermes.

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#248)

a5bea96

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: reference main branch of google-cloud-python (#248)

a9cc586

parthea pushed a commit that referenced this pull request Dec 20, 2024

chore(main): release 1.64.0 (#248)

a935692

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore: alphabetize class names (#248)

c324f61

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency nox to v2025 (#248)

17d9294

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 0.7.0 (#248)

84365ca

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: ensure enums are incomparable w other enum types (#248)

8f8deea

Fixes #247.

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: add api_key to client options (#248)

784f886

* feat: add api_key to client options * update

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 0.12.1-alpha (#248)

cc9d37d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: remove logging-v2-py.tar.gz from file tracking (#248)

77c1220

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: remove logging-v2-py.tar.gz from file tracking (#248)

3b2faf4

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore: remove logging-v2-py.tar.gz from file tracking (#248)

38188fe

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore: remove logging-v2-py.tar.gz from file tracking (#248)

4022a1e

Fix #239: remove / document 'pragma: NO COVER' #248

Fix #239: remove / document 'pragma: NO COVER' #248

Uh oh!

Conversation

tseaver commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

dhermes commented Oct 16, 2014

Uh oh!

dhermes commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

coveralls commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

tseaver commented Oct 16, 2014

Uh oh!

dhermes commented Oct 16, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants