Skip to content

Adding HappyBase to the umbrella package. #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Oct 3, 2016
Merged

Adding HappyBase to the umbrella package. #2469

dhermes merged 1 commit into from
Oct 3, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 30, 2016

Also

  • Updating umbrella README to also point out the HappyBase support
  • Make distinction in umbrella README between Homepage and API Documentation (they used to point to the same place)
  • Updating some HTTP links to HTTPS in README and CONTRIBUTING (I was surprised to find out that semver.org and Flask docs don't have HTTPS support.)

@dhermes
Adding HappyBase to the umbrella package.
d18a835 
Also

- Updating umbrella README to also point out the HappyBase support
- Make distinction in umbrella README between Homepage and
  API Documentation (they used to point to the same place)
- Updating some HTTP links to HTTPS in README and CONTRIBUTING
  (I was surprised to find out that semver.org and Flask docs
  don't have HTTPS support.)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 30, 2016

See https://github.com/dhermes/google-cloud-python/blob/add-happybase-refs/README.rst for preview of the changes

@daspecster
Copy link
Contributor

daspecster commented Sep 30, 2016 •
edited
Loading

@dhermes does this mess with that whole licensing thing from a while ago?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 30, 2016

I don't think so?

@daspecster
Copy link
Contributor

daspecster commented Sep 30, 2016

After re-reading that issue and noting https://github.com/GoogleCloudPlatform/google-cloud-python-happybase/blob/master/LICENSE I think I'm just being paranoid.

@dhermes
Copy link
Contributor Author

dhermes commented Oct 3, 2016

@jonparrott You think we're good to merge here?

@theacodes
Copy link
Contributor

theacodes commented Oct 3, 2016

Merge away.

@dhermes dhermes merged commit c055ee8 into googleapis:master Oct 3, 2016
@dhermes dhermes deleted the add-happybase-refs branch October 3, 2016 16:41
@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@renovate-bot @parthea
chore(deps): update all dependencies (#2469)
cc86c71 
Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@daspecster daspecster daspecster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @daspecster @theacodes @tseaver @googlebot