-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Rebase PR #99 and fix up #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hand apply / fix up patch from gsalgado's un-mergeable commit: gsalgado@1c80d61.
Manually applies patch from gsalgado: gsalgado@1c80d61 But changes semantics to return the new key instance, leaving the original key unchanged.
This was referenced Oct 7, 2014
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Incorporate feedback from @dhermes.
Contributor
|
LGTM pending Travis |
Contributor
|
That's the first time @coveralls has printed an increase. w00t! Travis is now passing so I'm going to merge. |
jgeewax
added a commit
that referenced
this pull request
Oct 12, 2014
I have a pending request to the GCS team asking if this is a reasonable thing to have exposed, however based on our conversations in #99 and #224 it seems that it needs to exist regardless (if we don't provide it, people will just do this on their own). That said, we need to be clear about what's happening under the hood in the short part of the docstring. If someone is frequently "renaming" 5TB objects (that's the maximum size currently), this could actually change their bill a lot and make the GCS API do some ridiculous amounts of work. For small objects this shouldn't really be a problem.
jgeewax
added a commit
to jgeewax/gcloud-python
that referenced
this pull request
Oct 12, 2014
I have a pending request to the GCS team asking if this is a reasonable thing to have exposed, however based on our conversations in googleapis#99 and googleapis#224 it seems that it needs to exist regardless (if we don't provide it, people will just do this on their own). That said, we need to be clear about what's happening under the hood in the short part of the docstring. If someone is frequently "renaming" 5TB objects (that's the maximum size currently), this could actually change their bill a lot and make the GCS API do some ridiculous amounts of work. For small objects this shouldn't really be a problem.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
Committer: @cherba PiperOrigin-RevId: 389755489 Source-Link: googleapis/googleapis@10185d0 Source-Link: googleapis/googleapis-gen@27d21b1
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
Committer: @cherba PiperOrigin-RevId: 389755489 Source-Link: googleapis/googleapis@10185d0 Source-Link: googleapis/googleapis-gen@27d21b1
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
Committer: @cherba PiperOrigin-RevId: 389755489 Source-Link: googleapis/googleapis@10185d0 Source-Link: googleapis/googleapis-gen@27d21b1
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
Committer: @cherba PiperOrigin-RevId: 389755489 Source-Link: googleapis/googleapis@10185d0 Source-Link: googleapis/googleapis-gen@27d21b1
parthea
pushed a commit
that referenced
this pull request
May 31, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
…224) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
…224) Source-Link: googleapis/synthtool@95d9289 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
…urce message (#224) * feat: make reservation_name parameter generally visible in QueuedResource message --- feat: add DeleteQueuedResource experiment --- docs(v2alpha1): minor formatting to the description for `queued_resource_id` PiperOrigin-RevId: 524336094 Source-Link: googleapis/googleapis@cad90d2 Source-Link: googleapis/googleapis-gen@848f9c2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODQ4ZjljMjk0MDc2ZGI2ZDFkMWE3ODAxMzA0MDI1MWIxYzBhZDdhOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Jun 4, 2023
* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0
parthea
added a commit
that referenced
this pull request
Jun 4, 2023
* chore: Prepare for mono repository migration * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
added a commit
that referenced
this pull request
Oct 21, 2023
The print statement in the print_get_metadata_response was printing the custom definition status of a dimension when it was supposed to be printing information about the custom definition status of a metric Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: googleapis/synthtool@6252f2c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:50e35228649c47b6ca82aa0be3ff9eb2afce51c82b66c4a03fe4afeb5ff6c0fc
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
…p/templates/python_library/.kokoro (#224) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Committer: @cherba PiperOrigin-RevId: 389755489 Source-Link: googleapis/googleapis@10185d0 Source-Link: googleapis/googleapis-gen@27d21b1
parthea
pushed a commit
that referenced
this pull request
Oct 31, 2023
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
parthea
pushed a commit
that referenced
this pull request
Jan 10, 2025
Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* docs: pandas DataFrame samples are more standalone * fix region tag * fix region tag * remove unused imports * blacken * remove session from call to rows/to_dataframe
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
🤖 I have created a release \*beep\* \*boop\* --- ### [2.6.1](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.6.0...v2.6.1) (2021-07-20) ### Bug Fixes * **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#240](https://www.github.com/googleapis/python-bigquery-storage/issues/240)) ([8f848e1](https://www.github.com/googleapis/python-bigquery-storage/commit/8f848e18379085160492cdd2d12dc8de50a46c8e)) ### Documentation * pandas DataFrame samples are more standalone ([#224](https://www.github.com/googleapis/python-bigquery-storage/issues/224)) ([4026997](https://www.github.com/googleapis/python-bigquery-storage/commit/4026997d7a286b63ed2b969c0bd49de59635326d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* docs: pandas DataFrame samples are more standalone * fix region tag * fix region tag * remove unused imports * blacken * remove session from call to rows/to_dataframe
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
🤖 I have created a release \*beep\* \*boop\* --- ### [2.6.1](https://www.github.com/googleapis/python-bigquery-storage/compare/v2.6.0...v2.6.1) (2021-07-20) ### Bug Fixes * **deps:** pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x versions ([#240](https://www.github.com/googleapis/python-bigquery-storage/issues/240)) ([8f848e1](https://www.github.com/googleapis/python-bigquery-storage/commit/8f848e18379085160492cdd2d12dc8de50a46c8e)) ### Documentation * pandas DataFrame samples are more standalone ([#224](https://www.github.com/googleapis/python-bigquery-storage/issues/224)) ([4026997](https://www.github.com/googleapis/python-bigquery-storage/commit/4026997d7a286b63ed2b969c0bd49de59635326d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
* parse all datetime types * typo * new black version * I tihnk we're doing similar things twice * better type tests * check nulls before assigning type * add env to gitignore * remove old code * handle float and int columns re nulls * nullable int columns as floats (separate issue) * Chesterton's Fence * try falling back to standard black check * exclude nox * changelog
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…cp/templates/python_library/.kokoro (#224) Source-Link: googleapis/synthtool@b4fe62e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: https://togithub.com/googleapis/synthtool/commit/dede53ff326079b457cfb1aae5bbdc82cbb51dc3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Note that the synthtool-generated `.coveragerc` (see #224) does *not* include all changes needed for 100% coverage: see: - googleapis/gapic-generator-python#171 - googleapis/gapic-generator-python#437 Closes #92. Closes #195.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Closes #214. Closes #215. Closes #216. Co-authored-by: Christopher Wilcox <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 25, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase gsalgado's changes from #99, adding tests.
Also, change the semantics of 'Key.rename' to return the new key without mutating the original.