Adding base pylint rcfile and plugin for unittests. #221

dhermes · 2014-10-04T22:24:02Z

No description provided.

dhermes · 2014-10-04T22:27:04Z

@tseaver This is a start towards getting our code clean without having to sprinkle comments as you mentioned before.

I had a lot of fun learning a bit about the internals of pylint and astroid. However, I'm not sure building a world class code inspection library is worth the trade-off relative to just using pylint: disable.

LMK what you think.

coveralls · 2014-10-04T22:32:42Z

Coverage increased (+0.0%) when pulling 67417e0 on dhermes:unittest-pylint-plugin into e30de64 on GoogleCloudPlatform:master.

dhermes · 2014-10-06T19:34:54Z

@silvolu @tseaver Here

silvolu · 2014-10-06T23:37:22Z

The plugin looks very slick, but I'm worried about the maintenance cost; also, if I understand correctly, comments are the most common way of handling this, is that correct?

dhermes · 2014-10-06T23:45:16Z

I'm trying to read up on best practices / things people do on the web.

This comment seems interesting:

QUES: How do you handle people adding lots of pylint disable commands? We fail the build on pylint on pylint errors, and Django/Celery peculiarities require us to disable those messages to prevent build failures. Unfortunately, that practice has spread, and we have lots disable statements for things that truly are code smell (e.g. too many local variables, etc.).

ANS: We have a custom .pylintrc file that is under source control. Disabling checks inline is not permissable and changes to the .pylintrc file are carefully reviewed for appropriateness.

I'm also looking into pyflakes as a SO post seems to indicate it is a nice best practice as well.

tseaver · 2014-10-07T03:13:28Z

As in that answer, ISTM that enforcing project policy through a .pylintrc file and a ban on inline comments disabling lint leads to the best code quality.

dhermes · 2014-10-07T03:41:04Z

Yes it seems to be a policy which is alive and well in the Python ecosystem. I'd be interested to hear what people do in cases like this.

In reality, a class with 47 public methods is doing too much, but having pylint complain about the 47 public methods "owned" by our unittest2.TestCase subclass is a bit silly. I'm not sure how one modifies it as the only setting I know of is

[DESIGN]
max-public-methods=20

coveralls · 2014-10-07T04:01:23Z

Changes Unknown when pulling f85eeba on dhermes:unittest-pylint-plugin into * on GoogleCloudPlatform:master*.

coveralls · 2014-10-07T04:07:40Z

Coverage increased (+0.0%) when pulling f85eeba on dhermes:unittest-pylint-plugin into 6dd5f2b on GoogleCloudPlatform:master.

gcloud/test_credentials.py

tseaver · 2014-10-07T19:13:59Z

Feel free to ignore the other "Invert the test and nest the following code?" comments if you don't find the first helpful.

dhermes · 2014-10-07T19:20:57Z

Gotcher. I will handle uniformly depending on the resolution of our discussion.

* chore(samples): Adding samples for custom hostname * chore(samples): Changing zone for tests, as europe-central2-c seems to have capcity issues with e2 instances.

Source-Link: googleapis/synthtool@52aef91 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

@busunkim96

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

* chore(python): use cov_level in unittest gh action Source-Link: googleapis/synthtool@e5aaa84 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:d22cd2ddce65fdac6986f115563faf2fc81482b09dfbea83ac2808c92ecfdff0 * set coverage to 100% Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix build Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@25083af Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

These two lines bring the rules on this repo in line with the defaults: https://github.com/googleapis/repo-automation-bots/blob/63c858e539e1f4d9bb8ea66e12f9c0a0de5fef55/packages/sync-repo-settings/src/required-checks.json#L40-L50

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@a37f74c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:d3de8a02819f65001effcbd3ea76ce97e9bcff035c7a89457f40f892c87c5b32 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@dede53f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

Fix for #221 : Client class name changes from monolith gapic

Source-Link: googleapis/synthtool@5c0fa62 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0ffe3bdd6c7159692df5f7744da74e5ef19966288a6bf76023e8e04e0c424d7d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python PiperOrigin-RevId: 423842556 Source-Link: googleapis/googleapis@a616ca0 Source-Link: googleapis/googleapis-gen@29b938c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Closes #221

…turedProperty`. (#221) This was in the original code, but was overlooked when porting. Fixes #216.

beriberikix added the in progress label Oct 4, 2014

dhermes mentioned this pull request Oct 4, 2014

Making all modules in gcloud package pylint compliant. #210

Closed

dhermes added the hygiene label Oct 5, 2014

dhermes force-pushed the unittest-pylint-plugin branch 2 times, most recently from e2dfbce to f85eeba Compare October 7, 2014 03:57

dhermes force-pushed the unittest-pylint-plugin branch 2 times, most recently from 063031d to 21b4574 Compare October 7, 2014 18:38

tseaver reviewed Oct 7, 2014
View reviewed changes

gcloud/test_credentials.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added the testing label Oct 7, 2014

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.6.1 (#221)

d63833d

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: use python-samples-reviewers (#221)

0ba9628

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-vision to v2.4.2 (#221)

e495542

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): disable dependency dashboard (#221)

30bbc37

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.12.0 (#221)

4e52f12

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-translate to v3.3.2 (#221)

20d7166

parthea pushed a commit that referenced this pull request Dec 20, 2024

chore(main): release 1.63.1 (#221)

17c6cea

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

Change generated client class name to have 'Client' at the end (#223)

011659a

Fix for #221 : Client class name changes from monolith gapic

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-documentai to v2.21.0 (#221)

1204767

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: add retry/timeout to manual surface (#222)

8b005f6

Closes #221

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-logging to v2.3.0 (#221)

3affb49

parthea pushed a commit that referenced this pull request Nov 24, 2025

Implement _prepare_for_put for StructuredProperty and `LocalStruc…

ddc8d7e

…turedProperty`. (#221) This was in the original code, but was overlooked when porting. Fixes #216.

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency google-cloud-logging to v2.3.0 (#221)

05724cc

Adding base pylint rcfile and plugin for unittests. #221

Adding base pylint rcfile and plugin for unittests. #221

Uh oh!

Conversation

dhermes commented Oct 4, 2014

Uh oh!

dhermes commented Oct 4, 2014

Uh oh!

coveralls commented Oct 4, 2014

Uh oh!

dhermes commented Oct 6, 2014

Uh oh!

silvolu commented Oct 6, 2014

Uh oh!

dhermes commented Oct 6, 2014

Uh oh!

tseaver commented Oct 7, 2014

Uh oh!

dhermes commented Oct 7, 2014

Uh oh!

coveralls commented Oct 7, 2014

Uh oh!

coveralls commented Oct 7, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Oct 7, 2014

Uh oh!

dhermes commented Oct 7, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants