Fixed a majority of pep8 errors in gcloud. #200

kleyow · 2014-09-28T04:27:49Z

No description provided.

dhermes · 2014-09-28T17:52:25Z

I should run pep8 with 2 indents, i.e. pep8 --ignore=E111 gcloud/connection.py?

gcloud/datastore/__init__.py

dhermes · 2014-09-28T18:02:06Z

$ pep8 --ignore=E111 gcloud/datastore/demo/__init__.py 
gcloud/datastore/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/entity.py 
gcloud/datastore/entity.py:46:80: E501 line too long (86 > 79 characters)
gcloud/datastore/entity.py:51:80: E501 line too long (83 > 79 characters)
gcloud/datastore/entity.py:58:80: E501 line too long (84 > 79 characters)
gcloud/datastore/entity.py:71:80: E501 line too long (82 > 79 characters)
gcloud/datastore/entity.py:119:80: E501 line too long (88 > 79 characters)
gcloud/datastore/entity.py:124:80: E501 line too long (85 > 79 characters)
gcloud/datastore/entity.py:138:80: E501 line too long (101 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/acl.py 
gcloud/storage/acl.py:382:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/bucket.py 
gcloud/storage/bucket.py:105:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/connection.py 
gcloud/storage/connection.py:467:80: E501 line too long (80 > 79 characters)
gcloud/storage/connection.py:479:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py 
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/iterator.py 
gcloud/storage/iterator.py:149:80: E501 line too long (91 > 79 characters)
gcloud/storage/iterator.py:177:80: E501 line too long (85 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/key.py 
gcloud/storage/key.py:98:80: E501 line too long (81 > 79 characters)
gcloud/storage/key.py:211:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/storage/key.py:235:11: E123 closing bracket does not match indentation of opening bracket's line
$ pep8 --ignore=E111 gcloud/storage/test_bucket.py 
gcloud/storage/test_bucket.py:353:80: E501 line too long (80 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/test_connection.py 
gcloud/storage/test_connection.py:158:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:173:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:189:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:209:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:226:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:276:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:296:44: E241 multiple spaces after ':'

dhermes · 2014-09-28T18:04:16Z

To fix the indents, I have been testing out a combination of pep8ify and my own solution for indenting doscstrings (which pep8ify, pyfmt and other auto-format libraries fail on).

I am happy to continue that effort after this commit gets checked in.

We also want to pass pylint, as that checks code style in addition to syntax. We can discuss that more in #179

dhermes · 2014-09-28T18:31:48Z

I ran git ls-files gcloud*py and there were 13 Python files, not included in this commit.

Nine of them check out just fine:

gcloud/__init__.py
gcloud/credentials.py
gcloud/datastore/demo/__main__.py
gcloud/datastore/demo/demo.py
gcloud/datastore/helpers.py
gcloud/datastore/transaction.py
gcloud/demo.py
gcloud/storage/exceptions.py
gcloud/storage/test_exceptions.py

However, the following errors were detected:

$ pep8 --ignore=E111 gcloud/datastore/connection.py
gcloud/datastore/connection.py:76:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/connection.py:159:80: E501 line too long (81 > 79 characters)
gcloud/datastore/connection.py:229:80: E501 line too long (88 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/query.py
gcloud/datastore/query.py:50:7: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/query.py:66:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)

In addition, the file gcloud/datastore/datastore_v1_pb2.py is all kinds of messed up, but I presume we should leave it as-is. We should consider using a .gitattributes file to check it in as binary and also in #178 we should ignore this file in a programmatic PEP/pylint check.

tseaver · 2014-09-29T19:57:34Z

@dhermes definitely leave the generated 'datastore_v1_pb2.py' as-is.

gcloud/datastore/connection.py

tseaver · 2014-09-29T20:04:03Z

We need to debate / document the style guide (by reference / delta to whatever authoritative specs we choose), and then automate testing of them (e.g., via something like 'tox -e lint', including automating exceptions).

dhermes · 2014-09-29T20:13:43Z

RE: automation, I checked out this branch and tested every .py file with pep8 --ignore=E111. If @kleyow likes, we can do the whitespace fixes here too, or I'm happy to do it with pep8ify and my custom docstring indent script.

In addition to passing pep8 <file> I'd like to have our files pass pylint --reports=n without any warnings or errors.

kleyow · 2014-09-29T22:43:55Z

@dhermes Go ahead and do it with your script. Yep sounds good.

dhermes · 2014-09-29T22:54:02Z

@kleyow Since you've already done a bulk of the work, let's check this in and then I can tackle the rest with the automated tools.

You can ignore the two files left out: gcloud/storage/demo/__init__.py and gcloud/datastore/connection.py but can you try to resolve the issues in existing files?

@tseaver Does this sound good?

kleyow · 2014-09-29T22:59:23Z

Whoops misclicked, issues were fixed in kleyow@b8a989f

kleyow · 2014-09-29T23:06:11Z

Should I switch to

 headers = {
         'Content-Type': 'application/x-protobuf',
         'Content-Length': str(len(data)),
     }

in this ticket.

dhermes · 2014-09-29T23:08:22Z

Yes please do. Also run pep8 --ignore=E111 on each of the files to make sure they have no issues.

….0 (#200)

) Source-Link: https://togithub.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547

- [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: googleapis/googleapis@83d81b0 Source-Link: googleapis/googleapis-gen@2ff001f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9

adding label example when writing a timeseries in python Remaking this due to the commit lint failure in #200 and it being easier to just make a new PR. Closing #200. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [✔️] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-monitoring/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [✔️ for linter, unable to run the nox tests because of issues unrelated] Ensure the tests and linter pass - [✔️] Code coverage does not decrease (if any source code was changed) - [✔️, no doc updates required ] Appropriate docs were updated (if necessary) Fixes #200 🦕

…versions (#200) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10566.

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [3.7.1](https://www.github.com/googleapis/python-cloudbuild/compare/v3.7.0...v3.7.1) (2021-11-05) ### Bug Fixes * **deps:** require google-api-core >= 1.28.0, drop packaging dep ([f3fb436](https://www.github.com/googleapis/python-cloudbuild/commit/f3fb4367ba598506d4cdd296870b61a8ffad75ef)) ### Documentation * list oneofs in docstring ([f3fb436](https://www.github.com/googleapis/python-cloudbuild/commit/f3fb4367ba598506d4cdd296870b61a8ffad75ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 459095142 Source-Link: googleapis/googleapis@4f1be99 Source-Link: googleapis/googleapis-gen@ae686d9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9 feat: add audience parameter PiperOrigin-RevId: 456827138 Source-Link: googleapis/googleapis@23f1a15 Source-Link: googleapis/googleapis-gen@4075a85 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* add test for single row & column * remove old comment

Additional clean up following googleapis/google-auth-library-python-httplib2#197

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* feat: add iterator capability to *Iterator classes The *Iterator classes are only _iterables_, and this commit also makes them _iterators_, i.e. calling next(iterator) on them now works. * Make AsyncIterator an actual async iterator

Due to an upstream change in how a module was imported and referenced, we needed to update some of our compliance tests to match. Fixes #200 🦕 Fixes #201 🦕 Fixes #202 🦕 Fixes #203 🦕 Fixes #204 🦕 Fixes #205 🦕 Fixes #206 🦕 Fixes #207 🦕

* Refactored Entity loading and changed sorting to only occur if all ids are digits. --------- Co-authored-by: Holt Skinner <[email protected]>

…ed. (#200) * Fix OAuth2 credentials to inherit from ReadOnlyScoped instead of Scoped. * Remove unused pytest

dhermes mentioned this pull request Sep 28, 2014

Make sure code is PEP8 compliant #179

Closed

dhermes reviewed Sep 28, 2014
View reviewed changes

gcloud/datastore/__init__.py

This comment was marked as spam.

Sign in to view

kleyow force-pushed the pe8_pyflakes branch from 3f3d0f1 to b8a989f Compare September 28, 2014 19:33

dhermes mentioned this pull request Sep 29, 2014

Make datastore.entity PEP8 and pylint compliant #189

Merged

tseaver reviewed Sep 29, 2014
View reviewed changes

gcloud/datastore/connection.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes added in progress labels Sep 29, 2014

kleyow closed this Sep 29, 2014

beriberikix removed the in progress label Sep 29, 2014

kleyow reopened this Sep 29, 2014

kleyow force-pushed the pe8_pyflakes branch 3 times, most recently from 5efa5f1 to f4fc666 Compare September 30, 2014 22:29

Kevin Leyow added 3 commits September 30, 2014 17:59

Fixed a majority of pep8 errors in gcloud.

a23ffdc

Fixed long lines and some more pep8 errors.

d20be07

Reverted summary lines and changed closing brackets for addibility.

76e360c

kleyow force-pushed the pe8_pyflakes branch from f4fc666 to cd0843f Compare September 30, 2014 23:19

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-containeranalysis to v2.6…

9e05095

….0 (#200)

parthea pushed a commit that referenced this pull request Oct 21, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

13b6110

…versions (#200) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10566.

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.0 (#200)

0eca550

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 1.6.1 (#200)

57d51e4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency pytest to v7.1.1 (#200)

48c1a26

parthea pushed a commit that referenced this pull request Dec 20, 2024

feat: add api_version to google/api/client.proto (#200)

ad19794

parthea pushed a commit that referenced this pull request Jan 10, 2025

chore(main): release 1.7.1 (#200)

7fdd62d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 21, 2025

fix(deps): add packaging requirement (#200)

686c5e1

parthea pushed a commit that referenced this pull request Sep 16, 2025

fix(deps): add packaging requirement (#200)

80a1d41

parthea pushed a commit that referenced this pull request Sep 18, 2025

Add test for single row & column (#200)

f3b823c

* add test for single row & column * remove old comment

parthea pushed a commit that referenced this pull request Nov 22, 2025

build: migrate to flakybot (#200)

ff1f118

parthea added a commit that referenced this pull request Nov 24, 2025

chore(librarian): clean up owlbot files and pin image sha (#200)

4c48fb6

Additional clean up following googleapis/google-auth-library-python-httplib2#197

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 1.14.2 (#200)

daad511

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: Prevent sorting entities labeled in Document AI Workbench (#200)

a8c81b3

* Refactored Entity loading and changed sorting to only occur if all ids are digits. --------- Co-authored-by: Holt Skinner <[email protected]>

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: detect monitored resources on all GCP environments (#200)

9ebb844

parthea pushed a commit that referenced this pull request Nov 24, 2025

do not set meanings for compressed property when it has no value (#200)

0f5727f

parthea pushed a commit that referenced this pull request Nov 25, 2025

feat: detect monitored resources on all GCP environments (#200)

06cbced

parthea pushed a commit that referenced this pull request Nov 26, 2025

Fix OAuth2 credentials to inherit from ReadOnlyScoped instead of Scop…

cb5cba6

…ed. (#200) * Fix OAuth2 credentials to inherit from ReadOnlyScoped instead of Scoped. * Remove unused pytest

Fixed a majority of pep8 errors in gcloud. #200

Fixed a majority of pep8 errors in gcloud. #200

Uh oh!

Conversation

kleyow commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

tseaver commented Sep 29, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants