Resolve issues with GAE and os.path.expanduser() #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
gcloud/test__helpers.py
Outdated
| import pwd | ||
| del pwd | ||
| sys.modules['pwd'] = None # Blocks pwd from being imported. | ||
| project_id = self.callFUT('test-project-id') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tseaver, I cleaned up some redundant code as well. |
gcloud/_helpers.py
Outdated
| # Workaround for GAE not supporting pwd which is used by expanduser. | ||
| try: | ||
| full_config_path = os.path.expanduser(DEFAULT_CONFIGURATION_PATH) | ||
| search_paths.append(full_config_path) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster
force-pushed
the
fix-gae-default-project-id
branch
from
b806b92 to
b1d56a5
Compare
Contributor
|
FWIW, I'm filing a bug to get pwd enabled on GAE. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.expanduserimports thepwdmodule which is not supported by GAE.This should resolve #1922.