Drop 'Table.rename'. #1908
Merged
Drop 'Table.rename'. #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.
googlebot
added
the
cla: yes
Contributor
|
@tseaver looks like there is more to remove for this in the system-test and protos. |
Contributor
Author
|
@daspecster Thanks forthe catch! OK to merge now? |
Contributor
|
There's some in the proto as well. But if we don't care about that since it's generated then LGTM! |
Contributor
Author
Yup, the Eventually (see #1384), we'd like to get rid of both those directories and rely on |
This was referenced Jun 28, 2016
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.